Re: [PATCH] firmware: convert e100 driver to request_firmware()

[Jeff Garzik <jeff@garzik.org>]

David Woodhouse wrote:
> On Sun, 2008-06-15 at 14:44 -0400, Jeff Garzik wrote:
>> Each driver is _intimately_ tied to its firmware, so it only increases
>> headaches by separating two pieces of a single, cohesive whole.
> 
> On reflection, that argument _does_ make me inclined to modify my
> approach.
> 
> The _only_ thing that lets us justify the inclusion of this firmware
> blob in the kernel in the first place is the rather tenuous claim that
> it is "mere aggregation on a volume of a storage or distribution medium"
> -- as if it's just some kind of coincidence that these two pieces of
> work happen to be shipped together.
> 
> If they really are "intimately tied pieces of a single, cohesive whole",
> as you say, then the claim that it's "mere aggregation on a volume of a
> storage or distribution medium" loses whatever small amount of
> credibility it had in the first place, and we have no option but to
> remove the offending part immediately.
> 
> Revised patch follows....
> 
>  drivers/net/Kconfig |    1 
>  drivers/net/e100.c  |  281 +++++++++++++++-------------------------------------
>  2 files changed, 86 insertions(+), 196 deletions(-)

So, in response you separate them further?  No thanks.

Put the data in drivers/net/e100.firmware.  It makes no sense to have 
two parallel driver hierarchies, one for C source and one for firmwares.

And IMO I would think the best first step for all such drivers would be 
to add request_firmware() support _without_ touching the embedded 
firmware.  You are trying to stuff too much change into a single patch.

Such a step gets most of your driver modifications into the kernel with 
the least headache and controversy, while adding the quite-useful 
ability to have a driver load an external firmware instead of the 
embedded one.

request_firmware() infrastructure addition is clearly a separate and 
distinct change from moving/removing an embedded firmware.

	Jeff




-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php