From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@freescale.com>
Subject: Re: Thoughts on ASOC v2 driver architecture
Date: Mon, 16 Jun 2008 11:24:26 -0500
Message-ID: <485693BA.9010801@freescale.com>
References: <9e4733910806151110y13f171dct3948a1555608c0ee@mail.gmail.com>	
	<1213612755.6599.51.camel@odin>	
	<9e4733910806160626h12525bb5ydfb61acd62ef3f09@mail.gmail.com>	
	<4856776B.7040300@freescale.com>	
	<9e4733910806160732h2b1b42f3s1afde73ac8f92026@mail.gmail.com>	
	<20080616150337.GB22229@sirena.org.uk>	
	<9e4733910806160853o2970f281m239712d8a2619e91@mail.gmail.com>	
	<48568E60.10206@freescale.com>
	<9e4733910806160923u1e7b3688tba4af776db2ddeef@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from de01egw01.freescale.net (de01egw01.freescale.net
	[192.88.165.102])
	by alsa0.perex.cz (Postfix) with ESMTP id 2C16A243AB
	for <alsa-devel@alsa-project.org>;
	Mon, 16 Jun 2008 18:24:31 +0200 (CEST)
In-Reply-To: <9e4733910806160923u1e7b3688tba4af776db2ddeef@mail.gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Jon Smirl <jonsmirl@gmail.com>
Cc: ALSA-devel <alsa-devel@alsa-project.org>, Mark Brown <broonie@opensource.wolfsonmicro.com>
List-Id: alsa-devel@alsa-project.org

Jon Smirl wrote:

> The driver stays in sound/soc/fsl. It's only the creation of the
> device that moves. You just need to add this to
> arch/powerpc/platforms/86xx/mpc8610_hpcd.c and remove it from
> mpc8610_hpcd.c. Adding this to
> arch/powerpc/platforms/86xx/mpc8610_hpcd.c will have no effect if the
> mpc8610_hpcd.c driver is not to be found.

Ok, I'll do that.

> You've complicated it by creating two fabric devices but I believe
> your code could be changed to only make one.
> 
> static struct platform_device alsa_fabric = {
> 	.name		= "MPC8610HPCD",
> 	.id		= -1,
> };
> 
> static struct platform_device *devices[] = {
> 	&alsa_fabric,
> };
> 
> platform_add_devices(&devices[0], ARRAY_SIZE(devices));
> 
> 
> I'd rename the driver to something less generic.
> 	.name		= "MPC8610HPCD-fabric",

These are all good ideas.  Thanks.

-- 
Timur Tabi
Linux kernel developer at Freescale