All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Pelton <david.r.pelton@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: [PATCH] [MIPS] change EARLY_PRINTK default to n
Date: Mon, 16 Jun 2008 15:15:39 -0400	[thread overview]
Message-ID: <4856BBDB.6000306@gmail.com> (raw)


This patch changes the default for CONFIG_EARLY_PRINTK to n.  Prior to
this change, the presence of SYS_HAS_EARLY_PRINTK would always set
EARLY_PRINTK to y if either EMBEDDED or DEBUG_KERNEL were not set.  As
this is a debugging option, it should default to n.

Signed-off-by: David Pelton <david.r.pelton@gmail.com>
---

Hi,

while fiddling with kernel configuration options for the Broadcom eval
board I am working with, I noticed that turning off DEBUG_KERNEL would
make many bad things happen.  I did not get to the root cause, but I
think that some of the early printk drivers have some dependency on
functionality enabled by DEBUG_KERNEL.  The 2.6.25.6 kernel has a
default value of "y" for EARLY_PRINTK, and this default will be applied
anytime the platform claims to support early printk.  In particular, if
DEBUG_KERNEL is not selected, there is no way to disable EARLY_PRINTK.
This patch changes the default to "n" to avoid these problems.

- David Pelton


 arch/mips/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff -Nraup linux-2.6.25.6-clean/arch/mips/Kconfig linux-2.6.25.6/arch/mips/Kconfig
--- linux-2.6.25.6-clean/arch/mips/Kconfig      2008-06-09 14:27:19.000000000 -0400
+++ linux-2.6.25.6/arch/mips/Kconfig    2008-06-16 14:34:33.229160000 -0400
@@ -807,7 +807,7 @@ config DMA_NEED_PCI_MAP_STATE
 config EARLY_PRINTK
        bool "Early printk" if EMBEDDED && DEBUG_KERNEL
        depends on SYS_HAS_EARLY_PRINTK
-       default y
+       default n
        help
          This option enables special console drivers which allow the kernel
          to print messages very early in the bootup process.

             reply	other threads:[~2008-06-16 19:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-16 19:15 David Pelton [this message]
2008-07-28 16:26 ` [PATCH] [MIPS] change EARLY_PRINTK default to n Atsushi Nemoto
2008-07-30 16:38   ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4856BBDB.6000306@gmail.com \
    --to=david.r.pelton@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.