All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@kernel.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: make asm/asm.h work for asm code.
Date: Mon, 16 Jun 2008 15:48:51 -0700	[thread overview]
Message-ID: <4856EDD3.4080808@kernel.org> (raw)
In-Reply-To: <4856E3D3.2010207@goop.org>

Jeremy Fitzhardinge wrote:
> This is useful for unifying some pieces of asm code.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

Thinking about it some more, this should be possible to do cleaner like 
this:

#ifdef CONFIG_X86_32
# ifdef __ASSEMBLY__
#  define __ASM_SEL(a,b) a
# else
#  define __ASM_SEL(a,b) " " #a " "
# endif
#else
# ifdef __ASSEMBLY__
#  define __ASM_SEL(a,b) b
# else
#  define __ASM_SEL(a,b) " " #b " "
# endif
#endif

#define _ASM_INC    _ASM_SEL(incl,incq)
#define _ASM_DEC    _ASM_SEL(decl,decq)

/* ... etc ... */

  parent reply	other threads:[~2008-06-16 22:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-16 22:06 [PATCH] x86: make asm/asm.h work for asm code Jeremy Fitzhardinge
2008-06-16 22:44 ` H. Peter Anvin
2008-06-16 22:48 ` H. Peter Anvin [this message]
2008-06-16 23:08   ` Jeremy Fitzhardinge
2008-06-16 23:13     ` H. Peter Anvin
2008-06-17 20:45       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4856EDD3.4080808@kernel.org \
    --to=hpa@kernel.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.