From: Eric Miao <eric.y.miao@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-input <linux-input@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH] input: make mainstone-wm97xx.c depend on MACH_MAINSTONE instead of ARCH_PXA
Date: Tue, 17 Jun 2008 09:06:38 +0800 [thread overview]
Message-ID: <48570E1E.3070301@gmail.com> (raw)
In-Reply-To: <20080616120756.GA7302@rakim.wolfsonmicro.main>
Mark Brown wrote:
> On Mon, Jun 16, 2008 at 06:32:19PM +0800, Eric Miao wrote:
>> If this is totally mainstone specific.
>
>> Signed-off-by: Eric Miao <eric.miao@marvell.com>
>
> It is and it isn't. It's very thin and stands a reasonable chance of
> working with generic PXA systems - ideally at some point we will have
> the ability to pass platform data to AC97 devices which would let it run
> elsewhere. The driver was until very recently called pxa-wm97xx but
> renamed recently due to the fact that we can't assume it'll work on
> other things due to having the GPIO hookup hardcoded.
>
> I'd rather let it be visible but I'm not *too* bothered either way.
Mike Rapoport said it could be re-used for EM-X270, so I'd suggest this
better to be PXA generic, and pass platform data as you advised.
next prev parent reply other threads:[~2008-06-17 1:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 10:32 [PATCH] input: make mainstone-wm97xx.c depend on MACH_MAINSTONE instead of ARCH_PXA Eric Miao
2008-06-16 12:06 ` Mike Rapoport
2008-06-16 12:07 ` Mark Brown
2008-06-17 1:06 ` Eric Miao [this message]
2008-06-17 9:59 ` Mark Brown
2008-06-17 11:52 ` Mike Rapoport
2008-06-17 11:58 ` Mark Brown
2008-06-22 8:53 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48570E1E.3070301@gmail.com \
--to=eric.y.miao@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.