From: "H. Peter Anvin" <hpa@zytor.com>
To: Glauber Costa <glommer@gmail.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: merge setup_memory_map with e820
Date: Tue, 17 Jun 2008 09:04:15 -0700 [thread overview]
Message-ID: <4857E07F.3070209@zytor.com> (raw)
In-Reply-To: <5d6222a80806170531g50a72ea2r963bba8e404e619f@mail.gmail.com>
Glauber Costa wrote:
>> + boot_params.e820_entries = new_nr;
>> + if (copy_e820_map(boot_params.e820_map, boot_params.e820_entries) < 0) {
>> +#ifdef CONFIG_X86_64
>> + early_panic("Cannot find a valid memory map");
>> +#else
>
> Can't this be made dependant on HIGHMEM instead of X86_64? It seems
> high-memory dependant anyway. Also, are you sure
> this code that maps into himem would work with HIGHMEM disabled anyway?
>
Uhm... x86-64 and HIGHMEM are mutually exclusive.
Either way, it shouldn't be dependent on anything; there is no reason
why the #else clause can't be applied to both.
-hpa
next prev parent reply other threads:[~2008-06-17 16:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 20:03 [PATCH] x86: move e820_resource_resources to e820.c Yinghai Lu
2008-06-17 2:58 ` [PATCH] x86: merge setup_memory_map with e820 Yinghai Lu
2008-06-17 12:31 ` Glauber Costa
2008-06-17 16:04 ` H. Peter Anvin [this message]
2008-06-17 16:18 ` Yinghai Lu
2008-06-17 16:25 ` Glauber Costa
2008-06-17 17:39 ` H. Peter Anvin
2008-06-17 17:52 ` Yinghai Lu
2008-06-17 18:23 ` H. Peter Anvin
2008-06-18 14:30 ` Ingo Molnar
2008-06-18 18:06 ` [PATCH] x86: cleanup machine_specific_memory_setup Yinghai Lu
2008-06-19 0:27 ` [PATCH] x86: cleanup machine_specific_memory_setup v2 Yinghai Lu
2008-06-19 12:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4857E07F.3070209@zytor.com \
--to=hpa@zytor.com \
--cc=glommer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.