From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K8jZh-0007UZ-A6 for mharc-grub-devel@gnu.org; Tue, 17 Jun 2008 18:22:49 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8jZg-0007Tb-5D for grub-devel@gnu.org; Tue, 17 Jun 2008 18:22:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8jZe-0007SW-Hn for grub-devel@gnu.org; Tue, 17 Jun 2008 18:22:47 -0400 Received: from [199.232.76.173] (port=40017 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8jZe-0007SI-9y for grub-devel@gnu.org; Tue, 17 Jun 2008 18:22:46 -0400 Received: from khepri.openbios.org ([80.190.231.112]:7712) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K8jZd-00064t-RU for grub-devel@gnu.org; Tue, 17 Jun 2008 18:22:46 -0400 Received: from dslb-088-066-048-048.pools.arcor-ip.net ([88.66.48.48] helo=[192.168.0.27]) by khepri.openbios.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1K8jZJ-0006mG-Pf for grub-devel@gnu.org; Wed, 18 Jun 2008 00:22:25 +0200 Message-ID: <48583933.4080208@coresystems.de> Date: Wed, 18 Jun 2008 00:22:43 +0200 From: Stefan Reinauer Organization: coresystems GmbH User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) MIME-Version: 1.0 To: The development of GRUB 2 References: <20080617104448.2b43f109@gibibit.com> <20080617203710.GA31785@thorin> In-Reply-To: <20080617203710.GA31785@thorin> X-Enigmail-Version: 0.95.6 OpenPGP: id=3134D111 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Duff: Orig. Duff, Duff Lite, Duff Dry, Duff Dark, Raspberry Duff, Lady Duff, Red Duff, Tartar Control Duff X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Tidy up 'make' output X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jun 2008 22:22:48 -0000 Robert Millan wrote: > On Tue, Jun 17, 2008 at 10:44:48AM -0700, Colin D Bennett wrote: > >> with output that, in my opinion, makes it easier to see warnings and >> errors: >> >> COMPILE ../util/getroot.c >> COMPILE ../kern/device.c >> ../kern/device.c: In function 'grub_device_iterate': >> ../kern/device.c:84: warning: generating trampoline in object >> (requires executable stack) >> ../kern/device.c:84: warning: generating trampoline in object >> (requires executable stack) >> COMPILE ../kern/disk.c >> COMPILE ../kern/err.c >> COMPILE ../kern/misc.c >> > > I don't like the idea of hiding information this way. If the goal is to > catch warnings, I think -Werror can do a much better job (and catching > errors shouldn't be a problem unless you're using make -j or -k). > I would not consider this "hiding information". The information you see (CFLAGS for example) don't really change across the lines and there's always the chance to say V=1 to see all the compiler lines. The opposite: The current forest of duplicate information is really what is hiding the relevant information between a lot of uninteresting fuzz. Maybe, you guys would prefer to set V=1 as the default, so one would have to say V=0 to get above output? I am currently only compiling grub with make -s, because that is the only way to get any decently parsable output for finding issues in the code. Please, please, don't use -Werror. GRUB2 is currently hard enough to build and the build system is less than optimal and elegant. While I agree that clean code never throughs warnings, the amazing number of different gccs and build environments out there would make developing for grub2 and compiling it very hard. There are quite a number of warnings that do not matter because the developers simply know better than the compiler. -Werror will lead to ugly workarounds to suppress these warnings and make adoption of new tool chain versions a task from hell. Stefan -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info@coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866