From: Jeff Garzik <jeff@garzik.org>
To: Patrick McHardy <kaber@trash.net>
Cc: John Russo <john.russo@qlogic.com>,
shemminger@vyatta.com,
"Amar Mudrankit (Contractor - )" <amar.mudrankit@qlogic.com>,
netdev@vger.kernel.org, rdreier@cisco.com, "Kuchimanchi,
Ramachandra \(Contractor - \)"
<ramachandra.kuchimanchi@qlogic.com>,
"Poornima Kamath (Contractor - )" <poornima.kamath@qlogic.com>
Subject: Re: Fwd: [ofa-general] FW: QLogic vNIC Kernel Submission
Date: Tue, 17 Jun 2008 19:59:08 -0400 [thread overview]
Message-ID: <48584FCC.4060800@garzik.org> (raw)
In-Reply-To: <48582340.7010409@trash.net>
Patrick McHardy wrote:
> Frankly, you didn't even try to fix the most obvious mistakes in your
> interface, like duplication of existing interfaces (csum settings)
> and very unusual behaviour (state machine triggered device registation)
> before you started complaining (and both of these are *really* easy to
> do).
>
> That you were asked to migrate to sysfs is unfortunate. The fact is
> though that your driver is a virtual ethernet device, not an infiniband
> device, so it should use the proper APIs for this kind of device. Work
> has been going on for years to provide a uniform interface to the network
> and your interface is a move in the opposite direction.
That's pretty much my feeling.
Jeff
next prev parent reply other threads:[~2008-06-17 23:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <99863D2ED484D449811D97A4C44C9CBD7C50F7@EPEXCH2.qlogic.org>
2008-06-17 17:18 ` Fwd: [ofa-general] FW: QLogic vNIC Kernel Submission Amar Mudrankit
2008-06-17 18:34 ` Patrick McHardy
2008-06-17 19:14 ` Stephen Hemminger
[not found] ` <C07C40DB2364324799506DE8FF12F8D859E90D@EPEXCH1.qlogic.org>
2008-06-17 20:12 ` John Russo
2008-06-17 20:49 ` Patrick McHardy
2008-06-17 23:59 ` Jeff Garzik [this message]
2008-06-17 19:15 ` Patrick McHardy
2008-06-18 10:43 ` Jeff Garzik
2008-06-18 11:19 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48584FCC.4060800@garzik.org \
--to=jeff@garzik.org \
--cc=amar.mudrankit@qlogic.com \
--cc=john.russo@qlogic.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=poornima.kamath@qlogic.com \
--cc=ramachandra.kuchimanchi@qlogic.com \
--cc=rdreier@cisco.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.