From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: wangchen@cn.fujitsu.com, netdev@vger.kernel.org
Subject: Re: v2: [PATCH 2/3] netdevice: Fix promiscuity and allmulti overflow
Date: Wed, 18 Jun 2008 10:44:10 +0200 [thread overview]
Message-ID: <4858CADA.6020807@trash.net> (raw)
In-Reply-To: <20080617.215402.169100957.davem@davemloft.net>
David Miller wrote:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Wed, 18 Jun 2008 09:51:00 +0800
>> Patrick McHardy said the following on 2008-6-17 20:59:
>>> Assuming the caller does proper error handling, that printk is
>>> not true.
>> Yes.
>> But currently, no caller handling this, and I think even if I make
>> some callers to handle this, but there maybe some callers and their
>> callers do not want to handle error condition.
>> So I need a KERN_WARNING here.
>> If some day, all of the caller handle the error properly, we can
>> remove this printk.
>>
>> Here is v3:
>
> Patrick, ACK?
Yes, thanks.
next prev parent reply other threads:[~2008-06-18 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 9:15 RFC: [PATCH 2/3] netdevice: Fix promiscuity and allmulti overflow Wang Chen
2008-06-16 9:38 ` Patrick McHardy
2008-06-16 9:51 ` Wang Chen
2008-06-16 10:04 ` Patrick McHardy
2008-06-16 15:05 ` v2: " Wang Chen
2008-06-17 12:59 ` Patrick McHardy
2008-06-18 1:51 ` Wang Chen
2008-06-18 4:54 ` David Miller
2008-06-18 8:44 ` Patrick McHardy [this message]
2008-06-18 8:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4858CADA.6020807@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.