From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, tglx <tglx@linutronix.de>,
hpa <hpa@zytor.com>, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg_constant
Date: Wed, 18 Jun 2008 16:09:58 +0300 [thread overview]
Message-ID: <48590926.5060009@movial.fi> (raw)
In-Reply-To: <20080614204452.25378bd0@paolo-desktop>
Paolo Ciarrocchi wrote:
>
> -static void fld_const(FPU_REG const *c, int adj, u_char tag)
> +static void fld_const(FPU_REG const * c, int adj, u_char tag)
________________________________________^
The above does not seem to me like a big improvement in code quality. A
false positive from checkpatch.pl?
Dmitri
> {
> FPU_REG *st_new_ptr;
>
next prev parent reply other threads:[~2008-06-18 13:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 18:44 [PATCH] x86: coding style fixes to arch/x86/math-emu/reg_constant Paolo Ciarrocchi
2008-06-18 13:01 ` Ingo Molnar
2008-06-18 13:09 ` Dmitri Vorobiev [this message]
2008-06-18 14:19 ` Paolo Ciarrocchi
2008-06-18 14:56 ` Stefan Richter
2008-06-19 9:07 ` Andy Whitcroft
2008-06-19 9:19 ` Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48590926.5060009@movial.fi \
--to=dmitri.vorobiev@movial.fi \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paolo.ciarrocchi@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.