From: "Séguier Régis" <rseguier@e-teleport.net>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arjan van de Ven <arjan@infradead.org>,
alan@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bug during MTU change
Date: Thu, 19 Jun 2008 00:09:08 +0200 [thread overview]
Message-ID: <48598784.40306@e-teleport.net> (raw)
In-Reply-To: <20080618201012.GA4019@electric-eye.fr.zoreil.com>
Francois Romieu a écrit :
> Séguier Régis <rseguier@e-teleport.net> :
> [...]
>
>> This correction seems to work.
>>
>> I read somewhere pci_free_consistent (in velocity_free_dma_rings) couldn't
>> be use in a spin_lock.
>>
>
> Yup.
>
>
>> When I move velocity_free_rings outside the spin_lock, error desappeare but
>> data transfert doesn't work after the mtu change.
>> When I add velocity_give_many_rx_descs all work.
>>
>
> I have updated http://userweb.kernel.org/~romieu/via-velocity/2.6.26-rc6/
> accordingly. Can you check whether it is fine or not ?
>
>
Patch 0001 doesn't work,
if I don't make a mistake skb->len is not modified in skb_pad{,to}when
the padding is applied. In this case, we need to attribute ETH_ZLEN to len.
--
Régis
next prev parent reply other threads:[~2008-06-18 22:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 1:46 [PATCH] net: via-velocity.c fix sleep-with-spinlock bug during MTU change Arjan van de Ven
2008-06-03 20:40 ` Andrew Morton
2008-06-03 21:51 ` Francois Romieu
2008-06-04 21:59 ` Francois Romieu
2008-06-14 21:23 ` Francois Romieu
2008-06-16 17:21 ` Séguier Régis
2008-06-16 21:17 ` Séguier Régis
2008-06-16 21:25 ` Séguier Régis
2008-06-17 21:45 ` Francois Romieu
2008-06-17 23:37 ` Séguier Régis
2008-06-18 16:56 ` Séguier Régis
2008-06-18 20:10 ` Francois Romieu
2008-06-18 22:09 ` Séguier Régis [this message]
2008-06-19 20:43 ` Francois Romieu
2008-06-20 10:24 ` Séguier Régis
2008-06-20 10:39 ` Francois Romieu
2008-06-20 16:50 ` Séguier Régis
2008-06-23 17:04 ` Séguier Régis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48598784.40306@e-teleport.net \
--to=rseguier@e-teleport.net \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.