From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>, luke@lukeross.name
Subject: Re: [PATCH #upstream-fixes 1/2] libata: don't check whether to use DMA or not for no data commands
Date: Wed, 18 Jun 2008 20:28:53 -0400 [thread overview]
Message-ID: <4859A845.5060302@garzik.org> (raw)
In-Reply-To: <4857313A.1000405@kernel.org>
Tejun Heo wrote:
> There's no reason to check whether to use DMA or not for no data
> commands. Don't do it. While at it, make local variable using_pio in
> atapi_xlat() set iff ATAPI_PROT_PIO is going to be used and rename
> ata_check_atapi_dma() to atapi_check_dma() for consistency.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> It's late in the -rc cycle but these two patches are to work around
> specific hardware and low risk. Thanks.
>
> drivers/ata/libata-core.c | 4 ++--
> drivers/ata/libata-scsi.c | 16 +++++++---------
> drivers/ata/libata.h | 2 +-
> 3 files changed, 10 insertions(+), 12 deletions(-)
applied this (patch #1)
dropped patch #2 per discussion
prev parent reply other threads:[~2008-06-19 0:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 3:36 [PATCH #upstream-fixes 1/2] libata: don't check whether to use DMA or not for no data commands Tejun Heo
2008-06-17 3:37 ` [PATCH #upstream-fixes 2/2] libata: implement ATAPI_HORKAGE_NOPIO and apply it to GGW-H10N Tejun Heo
2008-06-17 8:43 ` Alan Cox
2008-06-17 9:14 ` Tejun Heo
2008-06-17 9:31 ` Tejun Heo
2008-06-17 9:54 ` Luke Ross
2008-06-17 10:04 ` Alan Cox
2008-06-17 12:27 ` Tejun Heo
2008-06-18 11:48 ` Luke Ross
2008-06-18 11:59 ` Jeff Garzik
2009-11-13 9:14 ` Dan Williams
2009-11-14 0:11 ` Robert Hancock
2009-11-15 8:16 ` Tejun Heo
2009-11-15 18:22 ` Robert Hancock
2009-11-18 2:14 ` Jeff Garzik
2009-11-24 16:50 ` Dan Williams
2009-11-15 11:13 ` Luke Ross
2008-06-17 8:54 ` Alan Cox
2008-06-19 0:28 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4859A845.5060302@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=luke@lukeross.name \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.