From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: dccp@vger.kernel.org
Subject: Re: QUESTION : Feature length about the non-negotiable feature
Date: Thu, 19 Jun 2008 07:18:47 +0000 [thread overview]
Message-ID: <485A0857.1050508@cn.fujitsu.com> (raw)
In-Reply-To: <48579530.4010807@cn.fujitsu.com>
Gerrit Renker wrote:
>>> Thus, although the RFC says otherwise, I think that using the smallest
>>> option size for a given value is the right thing to do.
>>>
>>>
>>>
>> Yes, you can save some space for store more data, but this break the
>> compatibility. If the other system implement follow the RFC, since those
>> feature will be treat as invalid value. Also if it is set as mandatory
>> option, assoc will be reset. endpoint with different implement can not
>> talk to each other. That is the problem.
>>
>>
> After your email yesterday I checked the RFC and found it indeed uses
> fixed lengths. I have therefore updated the code so that the NN options
> have the described fixed lengths (Ack Ratio = 2, Sequence Window = 6).
>
> This has been tested, I will post the changelog for the test tree
> shortly and upload the amended tree. I would be grateful if you could
> give this a spin with your test cases.
>
>
With the patch, it is OK for send non-negotiable features. But not valid
for check invalid value when recv.
next prev parent reply other threads:[~2008-06-19 7:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 10:42 QUESTION : Feature length about the non-negotiable feature Wei Yongjun
2008-06-17 11:02 ` Gerrit Renker
2008-06-17 14:08 ` Eddie Kohler
2008-06-18 0:56 ` Wei Yongjun
2008-06-18 6:36 ` Gerrit Renker
2008-06-18 8:16 ` Gerrit Renker
2008-06-19 7:18 ` Wei Yongjun [this message]
2008-06-19 8:21 ` Gerrit Renker
2008-06-19 11:42 ` Eddie Kohler
2008-06-19 13:38 ` Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485A0857.1050508@cn.fujitsu.com \
--to=yjwei@cn.fujitsu.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.