All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [Patch] U-Boot-v2: general replace __KERNEL__ with	__UBOOT__
Date: Thu, 19 Jun 2008 07:53:59 -0500	[thread overview]
Message-ID: <485A56E7.1020102@freescale.com> (raw)
In-Reply-To: <7A436F7769CA33409C6B44B358BFFF0CD32118B5@dlee02.ent.ti.com>

Menon, Nishanth wrote:
> Robert,
>> -----Original Message-----
>> From: Robert Schwebel [mailto:r.schwebel at pengutronix.de]
>> Sent: Wednesday, June 18, 2008 2:02 PM
>> To: Menon, Nishanth
>> Cc: Sascha Hauer; Laurent Desnogues; Kamat, Nishant; philip.balister at gmail.com; u-boot-
>> users at lists.sourceforge.net
>> Subject: Re: [U-Boot-Users] [Patch 1/9] U-boot-V2:ID: Sync mod_devicetable
>>
>>> +
>>> +#ifndef LINUX_MOD_DEVICETABLE_H
>>> +#define LINUX_MOD_DEVICETABLE_H
>>> +
>>> +#ifdef __KERNEL__
>>> +#include <linux/types.h>
>>> +typedef unsigned long kernel_ulong_t;
>>> +#endif
>> No Linux, no __KERNEL__.


All the above crap should appear below the following "---" line.

> Here is a patch to cleanup all other occurrences currently in u-boot v2. This is a blind replacement throughout. Do we want to consider replacing include/linux with include/u-boot?

That should be line-length-limited to about 70 characters.
The question should appear below the "---" line too.

And I'd suggest that, if we go this route as a whole, then
then the include directory should be renamed as well.

> Signed-off-by: Nishanth Menon <x0nishan@ti.com>
> 
> ---

Here.

jdl

  reply	other threads:[~2008-06-19 12:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18 12:33 [U-Boot-Users] [Patch 1/9] U-boot-V2:ID: Sync mod_devicetable Menon, Nishanth
2008-06-18 19:02 ` Robert Schwebel
2008-06-19  3:57   ` [U-Boot-Users] [Patch] U-Boot-v2: general replace __KERNEL__ with __UBOOT__ Menon, Nishanth
2008-06-19 12:53     ` Jon Loeliger [this message]
2008-06-19 13:05       ` Menon, Nishanth
2008-06-19 15:11         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485A56E7.1020102@freescale.com \
    --to=jdl@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.