From: "H. Peter Anvin" <hpa@zytor.com>
To: Ian Kent <raven@themaw.net>
Cc: autofs@linux.kernel.org, Anton Altaparmakov <aia21@cam.ac.uk>,
Unix Support <unix-support@ucs.cam.ac.uk>
Subject: Re: Horrible denial of service bug in autmount 5
Date: Fri, 20 Jun 2008 12:03:28 -0700 [thread overview]
Message-ID: <485BFF00.7020205@zytor.com> (raw)
In-Reply-To: <1213986137.4975.39.camel@raven.themaw.net>
Ian Kent wrote:
>> Okay, I'm confused... what reason could there *possibly* be for
>> searching /proc/*/cmdline? If there is a need for a mutex of some sort,
>> one should typically create a /var/run directory and put in lock files,
>> or some other solution to test the mutexing explicitly. grepping ps, in
>> effect, is hardly a good idea, to put it gently.
>
> This is nothing more than a check to see if another instance of
> automount(8) is running.
But it is an utterly daft way to implement something like that. If you
want a lock, create an explicit lock, but doing string-matching on
command lines is idiotic.
-hpa
next prev parent reply other threads:[~2008-06-20 19:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 13:24 Horrible denial of service bug in autmount 5 Anton Altaparmakov
2008-06-20 13:44 ` Ian Kent
2008-06-20 14:01 ` Anton Altaparmakov
2008-06-20 15:04 ` Ian Kent
2008-06-20 15:24 ` Anton Altaparmakov
2008-06-20 15:28 ` Ian Kent
2008-06-20 15:49 ` J.P. King
2008-06-20 16:07 ` Ian Kent
2008-06-20 16:22 ` J.P. King
2008-06-20 16:27 ` Ian Kent
2008-06-20 17:03 ` H. Peter Anvin
2008-06-20 18:22 ` Ian Kent
2008-06-20 19:03 ` H. Peter Anvin [this message]
2008-06-21 2:43 ` Ian Kent
2008-06-21 4:27 ` H. Peter Anvin
2008-06-21 4:44 ` Ian Kent
2008-06-21 4:54 ` H. Peter Anvin
2008-06-21 9:18 ` J.P. King
2008-06-23 1:53 ` Ian Kent
2008-06-23 2:26 ` J.P. King
2008-06-23 1:08 ` H. Peter Anvin
2008-06-23 5:33 ` Jim Carter
2008-06-23 8:06 ` Anton Altaparmakov
2008-06-23 9:03 ` Ian Kent
2008-06-23 9:12 ` Ian Kent
2008-06-23 9:18 ` Ian Kent
2008-06-24 1:08 ` Jim Carter
2008-06-24 7:27 ` Anton Altaparmakov
2008-06-24 7:38 ` Ian Kent
2008-06-24 8:08 ` Anton Altaparmakov
2008-06-24 18:46 ` Jim Carter
2008-06-24 18:55 ` Jim Carter
2008-06-24 19:18 ` Anton Altaparmakov
2008-06-23 2:40 ` Ian Kent
2008-06-23 2:55 ` J.P. King
2008-06-23 3:10 ` Ian Kent
2008-06-23 7:15 ` Anton Altaparmakov
2008-06-23 7:45 ` Ian Kent
2008-06-23 5:27 ` Jim Carter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485BFF00.7020205@zytor.com \
--to=hpa@zytor.com \
--cc=aia21@cam.ac.uk \
--cc=autofs@linux.kernel.org \
--cc=raven@themaw.net \
--cc=unix-support@ucs.cam.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.