Re: [PATCH] input: driver for USB VoIP phones with CM109 chipset

["Alfred E. Heggestad" <aeh@db.org>]

Hi Dmitry

Dmitry Torokhov wrote:
> Hi Alfred,
> 
> On Thu, Feb 07, 2008 at 07:38:10PM +0100, Alfred E. Heggestad wrote:
>> From: Alfred E. Heggestad <aeh@db.org>
>>
>> This driver adds support for USB VoIP phones using the CM109 chipset,
>> such as Komunikate KIP-1000 and Genius G-talk. Keypad is scanned and
>> events are reported to the input subsystem. The buzzer can be activated
>> by sending SND_TONE or SND_BELL to the input device. The phone keymap
>> can be selected in run-time by using the "phone" module parameter.
>> The driver has been tested with linux 2.6.24 on i386, and also tested
>> to build cleanly on AMD64.
>> More testing and code review is welcome..
>>
> 
> For a long time I was sitting on the patch not sure what to do about
> the pound key, but I think we need to allocate separate keycodes for
> remote controls and phones that work regardless of users keymap.
> 

do you think we could add a new KEY_KPPOUND to include/linux/input.h ?

I just had a quick look in latest git, but could not find anything..
do you want me to define a key and make a patch for you?

BTW, for now I have defined a work-around in my cm109 driver:

#ifndef KEY_KPPOUND
#define KEY_KPPOUND (KEY_LEFTSHIFT | KEY_3 << 8)
#endif

that hack was "copied" from drivers/input/misc/yealink.c

         case 0x32: return KEY_LEFTSHIFT |
                           KEY_3 << 8;   /*   #          */



/alfred


<snip>