From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
den@openvz.org, xemul@openvz.org, ebiederm@xmission.com,
benjamin.thery@bull.net, dlezcano@fr.ibm.com
Subject: Re: [PATCH 10/25] netns ct: fix ip_route_me_harder() for REEJCT, NAT et al
Date: Mon, 23 Jun 2008 12:40:35 +0200 [thread overview]
Message-ID: <485F7DA3.2010700@trash.net> (raw)
In-Reply-To: <20080622010920.GK5392@martell.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> ip_route_me_harder() is called on output codepaths:
> 1) IPVS: honestly, not sure, it can be called during forwarding
> 2) IPv4 REJECT: refreshing comment re skb->dst is valid
> and assigment of skb->dst right before call :^)
> 3) NAT: called in LOCAL_OUT hook
> 4) iptable_mangle: LOCAL_OUT hook
> 5) nf_ip_reroute(): LOCAL_OUT hook (no clue about queueing packets to luserspace)
skb->dst->dev seems OK in all these cases.
> P.S.: IPv6 version is also called by mangling code on input, what's the story
> behind this discrepancy?
That looks wrong, I think the reason for this bug is that
IPv6 originally didn't support routing rules, so the call
was #ifdef 0'ed, then enabled without checking the hooks.
I'll queue up a fix.
prev parent reply other threads:[~2008-06-23 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 1:09 [PATCH 10/25] netns ct: fix ip_route_me_harder() for REEJCT, NAT et al Alexey Dobriyan
2008-06-23 10:40 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485F7DA3.2010700@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=benjamin.thery@bull.net \
--cc=den@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.