From: Patrick McHardy <kaber@trash.net>
To: Wang Chen <wangchen@cn.fujitsu.com>
Cc: Joe Eykholt <jeykholt@cisco.com>,
David Miller <davem@davemloft.net>,
jgarzik@pobox.com, netdev@vger.kernel.org, fubar@us.ibm.com
Subject: Re: [PATCH net-next 2/8] bonding: Check return of dev_set_promiscuity/allmulti
Date: Mon, 23 Jun 2008 13:13:10 +0200 [thread overview]
Message-ID: <485F8546.9030209@trash.net> (raw)
In-Reply-To: <485EFE06.7040104@cn.fujitsu.com>
Wang Chen wrote:
> Joe Eykholt said the following on 2008-6-22 2:19:
>> If netdev->promiscuity overflows, shouldn't there be a WARN_ON or BUG_ON
>> that catches that? Either someone forgot to clean up, or much less likely,
>> the counter needs to be widened. It isn't necessarily the current caller's
>> fault, but some indication of the problem is better than nothing.
>>
>
> If promiscuity overflows, dev_set_promiscuity will printk(KERN_WARNING) now.
> Compare to that, WARN_ON has more information about modules info and dump stack.
> But I think printk has enough information to indicate the problem and we
> don't need WARN_ON.
> How do you think?
WARN_ON doesn't provide any useful information here, if the counter
overflowed, its because *something else* increased it by too much.
prev parent reply other threads:[~2008-06-23 11:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 0:54 [PATCH net-next 2/8] bonding: Check return of dev_set_promiscuity/allmulti Wang Chen
2008-06-20 2:07 ` David Miller
2008-06-20 2:56 ` Wang Chen
2008-06-21 18:19 ` Joe Eykholt
2008-06-23 1:36 ` Wang Chen
2008-06-23 3:55 ` Joe Eykholt
2008-06-23 11:13 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485F8546.9030209@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=jeykholt@cisco.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.