From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Tollefson Subject: Re: [RFC] hugetlb reservations -- MAP_PRIVATE fixes for split vmas Date: Mon, 23 Jun 2008 11:04:04 -0500 Message-ID: <485FC974.70403@linux.vnet.ibm.com> References: <485A8903.9030808@linux.vnet.ibm.com> <1213989474-5586-1-git-send-email-apw@shadowen.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1213989474-5586-1-git-send-email-apw-26w3C0LaAnFg9hUCZPvPmw@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Andy Whitcroft Cc: Andrew Morton , Nick Piggin , Nishanth Aravamudan , Adam Litke , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Mel Gorman Andy Whitcroft wrote: > As reported by Adam Litke and Jon Tollefson one of the libhugetlbfs > regression tests triggers a negative overall reservation count. When > this occurs where there is no dynamic pool enabled tests will fail. > > Following this email are two patches to fix this issue: > > hugetlb reservations: move region tracking earlier -- simply moves the > region tracking code earlier so we do not have to supply prototypes, and > > hugetlb reservations: fix hugetlb MAP_PRIVATE reservations across vma > splits -- which moves us to tracking the consumed reservation so that > we can correctly calculate the remaining reservations at vma close time. > > This stack is against the top of v2.6.25-rc6-mm3, should this solution > prove acceptable it would probabally need porting below Nicks multiple > hugepage size patches and those updated; if so I would be happy to do > that too. > > Jon could you have a test on this and see if it works out for you. > > -apw > Looking good so far. I am not seeing any of the tests push the reservation number negative - with this patch set applied Jon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759960AbYFWQEV (ORCPT ); Mon, 23 Jun 2008 12:04:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756066AbYFWQED (ORCPT ); Mon, 23 Jun 2008 12:04:03 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:40420 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759869AbYFWQEA (ORCPT ); Mon, 23 Jun 2008 12:04:00 -0400 Message-ID: <485FC974.70403@linux.vnet.ibm.com> Date: Mon, 23 Jun 2008 11:04:04 -0500 From: Jon Tollefson Organization: IBM User-Agent: Thunderbird 2.0.0.14 (X11/20080505) MIME-Version: 1.0 To: Andy Whitcroft CC: Andrew Morton , Nick Piggin , Nishanth Aravamudan , Adam Litke , linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, linux-mm@kvack.org, Mel Gorman Subject: Re: [RFC] hugetlb reservations -- MAP_PRIVATE fixes for split vmas References: <485A8903.9030808@linux.vnet.ibm.com> <1213989474-5586-1-git-send-email-apw@shadowen.org> In-Reply-To: <1213989474-5586-1-git-send-email-apw@shadowen.org> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Whitcroft wrote: > As reported by Adam Litke and Jon Tollefson one of the libhugetlbfs > regression tests triggers a negative overall reservation count. When > this occurs where there is no dynamic pool enabled tests will fail. > > Following this email are two patches to fix this issue: > > hugetlb reservations: move region tracking earlier -- simply moves the > region tracking code earlier so we do not have to supply prototypes, and > > hugetlb reservations: fix hugetlb MAP_PRIVATE reservations across vma > splits -- which moves us to tracking the consumed reservation so that > we can correctly calculate the remaining reservations at vma close time. > > This stack is against the top of v2.6.25-rc6-mm3, should this solution > prove acceptable it would probabally need porting below Nicks multiple > hugepage size patches and those updated; if so I would be happy to do > that too. > > Jon could you have a test on this and see if it works out for you. > > -apw > Looking good so far. I am not seeing any of the tests push the reservation number negative - with this patch set applied Jon From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e3.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m5NG460A021881 for ; Mon, 23 Jun 2008 12:04:06 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m5NG3tUe201366 for ; Mon, 23 Jun 2008 12:03:55 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m5NG3t96031229 for ; Mon, 23 Jun 2008 12:03:55 -0400 Message-ID: <485FC974.70403@linux.vnet.ibm.com> Date: Mon, 23 Jun 2008 11:04:04 -0500 From: Jon Tollefson MIME-Version: 1.0 Subject: Re: [RFC] hugetlb reservations -- MAP_PRIVATE fixes for split vmas References: <485A8903.9030808@linux.vnet.ibm.com> <1213989474-5586-1-git-send-email-apw@shadowen.org> In-Reply-To: <1213989474-5586-1-git-send-email-apw@shadowen.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Andy Whitcroft Cc: Andrew Morton , Nick Piggin , Nishanth Aravamudan , Adam Litke , linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, linux-mm@kvack.org, Mel Gorman List-ID: Andy Whitcroft wrote: > As reported by Adam Litke and Jon Tollefson one of the libhugetlbfs > regression tests triggers a negative overall reservation count. When > this occurs where there is no dynamic pool enabled tests will fail. > > Following this email are two patches to fix this issue: > > hugetlb reservations: move region tracking earlier -- simply moves the > region tracking code earlier so we do not have to supply prototypes, and > > hugetlb reservations: fix hugetlb MAP_PRIVATE reservations across vma > splits -- which moves us to tracking the consumed reservation so that > we can correctly calculate the remaining reservations at vma close time. > > This stack is against the top of v2.6.25-rc6-mm3, should this solution > prove acceptable it would probabally need porting below Nicks multiple > hugepage size patches and those updated; if so I would be happy to do > that too. > > Jon could you have a test on this and see if it works out for you. > > -apw > Looking good so far. I am not seeing any of the tests push the reservation number negative - with this patch set applied Jon -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org