From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Hancock Subject: Re: [PATCH 2.6.26-rc] ACPI Thermal Zone driver breaks lm-sensors 2 userspace Date: Mon, 23 Jun 2008 20:17:25 -0600 Message-ID: <48605935.5070407@shaw.ca> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from idcmail-mo1so.shaw.ca ([24.71.223.10]:54419 "EHLO pd3mo1so.prod.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbYFXCSA (ORCPT ); Mon, 23 Jun 2008 22:18:00 -0400 In-reply-to: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Mark M. Hoffman" Cc: Rene Herman , Linus Torvalds , Hans de Goede , Zhang Rui , Jean Delvare , linux-acpi@vger.kernel.org, lm-sensors@lm-sensors.org, Linux Kernel Mark M. Hoffman wrote: > Linus, Rene, et al: > > * Rene Herman [2008-06-23 17:06:14 +0200]: >> drivers/thermal/thermal_sys.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c >> index 6098787..c21e03c 100644 >> --- a/drivers/thermal/thermal_sys.c >> +++ b/drivers/thermal/thermal_sys.c >> @@ -357,7 +357,7 @@ thermal_add_hwmon_sysfs(struct thermal_zone_device *tz) >> >> INIT_LIST_HEAD(&hwmon->tz_list); >> strlcpy(hwmon->type, tz->type, THERMAL_NAME_LENGTH); >> - hwmon->device = hwmon_device_register(NULL); >> + hwmon->device = hwmon_device_register(&tz->device); >> if (IS_ERR(hwmon->device)) { >> result = PTR_ERR(hwmon->device); >> goto free_mem; > > NACK. > > 1) The bug is in libsensors (2.10), not the kernel. This doesn't matter. Breaking userspace in such a fashion is severely frowned upon unless essentially unavoidable, even if it is just triggering a bug. > > - but more importantly - > > 2) This patch is broken. You didn't indicate what was wrong with the patch. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Hancock Date: Tue, 24 Jun 2008 02:17:25 +0000 Subject: Re: [lm-sensors] [PATCH 2.6.26-rc] ACPI Thermal Zone driver breaks Message-Id: <48605935.5070407@shaw.ca> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Mark M. Hoffman" Cc: Rene Herman , Linus Torvalds , Hans de Goede , Zhang Rui , Jean Delvare , linux-acpi@vger.kernel.org, lm-sensors@lm-sensors.org, Linux Kernel Mark M. Hoffman wrote: > Linus, Rene, et al: > > * Rene Herman [2008-06-23 17:06:14 +0200]: >> drivers/thermal/thermal_sys.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c >> index 6098787..c21e03c 100644 >> --- a/drivers/thermal/thermal_sys.c >> +++ b/drivers/thermal/thermal_sys.c >> @@ -357,7 +357,7 @@ thermal_add_hwmon_sysfs(struct thermal_zone_device *tz) >> >> INIT_LIST_HEAD(&hwmon->tz_list); >> strlcpy(hwmon->type, tz->type, THERMAL_NAME_LENGTH); >> - hwmon->device = hwmon_device_register(NULL); >> + hwmon->device = hwmon_device_register(&tz->device); >> if (IS_ERR(hwmon->device)) { >> result = PTR_ERR(hwmon->device); >> goto free_mem; > > NACK. > > 1) The bug is in libsensors (2.10), not the kernel. This doesn't matter. Breaking userspace in such a fashion is severely frowned upon unless essentially unavoidable, even if it is just triggering a bug. > > - but more importantly - > > 2) This patch is broken. You didn't indicate what was wrong with the patch. _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors