From: Wang Chen <wangchen@cn.fujitsu.com>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH net-next 5/8] ipv6: Check return of dev_set_allmulti
Date: Tue, 24 Jun 2008 13:01:43 +0800 [thread overview]
Message-ID: <48607FB7.9050908@cn.fujitsu.com> (raw)
In-Reply-To: <20080624.125243.112730755.yoshfuji@linux-ipv6.org>
YOSHIFUJI Hideaki / 吉藤英明 said the following on 2008-6-24 11:52:
> In article <485AFFFB.5040901@cn.fujitsu.com> (at Fri, 20 Jun 2008 08:55:23 +0800), Wang Chen <wangchen@cn.fujitsu.com> says:
>
>> allmulti might overflow.
>> Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
>> dev_set_promiscuity/allmulti return error number if overflow happened.
>>
>> Here, we check the positive increment for allmulti to get error return.
>>
>> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
>
> The comment is too obvious to have.
>
It's just explain the background of this series of fix.
prev parent reply other threads:[~2008-06-24 5:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 0:55 [PATCH net-next 5/8] ipv6: Check return of dev_set_allmulti Wang Chen
2008-06-20 2:09 ` David Miller
2008-06-20 3:06 ` Wang Chen
2008-06-24 3:52 ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-24 5:01 ` Wang Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48607FB7.9050908@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.