[Qemu-devel] Re: [RESENT][PATCH 2/2] x86: Issue reset on triple faults

[Kevin Wolf <kwolf@suse.de>]

Jan Kiszka schrieb:
> Jamie Lokier wrote:
>> It might be worth distinguishing between
>> triple-fault-used-by-guest-for-context-switch and triple faults which
>> trigger a normal reset, and log only the latter.  There's a
>> standardish way of distinguishing them, which the BIOS should check.

Well, that's certainly possible somehow. But then you need to rename the 
cpu_reset option to cpu_resets_suspected_to_be_errors. Let's keep it 
simple and just log all of them.

>>> +#if !defined(CONFIG_USER_ONLY)
>>> +    if (env->old_exception == EXCP08_DBLE) {
>>> +        if (env->hflags & HF_SVMI_MASK)
>>> +            helper_vmexit(SVM_EXIT_SHUTDOWN, 0);
>>> +
>>> +        if (loglevel & CPU_LOG_RESET)
>>> +            fprintf(logfile, "Triple fault\n");
>>> +
>>> +        qemu_system_reset_request();
>>> +        return EXCP_HLT;
>>> +    }
>>> +#endif
>> When helper(SVM_EXIT_SHUTDOWN, 0) is called, should it still also call
>> qemu_system_reset_request()?
> 
> helper_vmexit() is not expected to return (cpu_loop_exit).

Maybe a comment then?

Kevin