Re: [Resend] [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

[Arun KS <arunks@mistralsolutions.com>]

Hi Felipe,

Thanks for your comments. I will incorporate those changes
and will send back.

Regards
Arun
Felipe Balbi wrote:
> Hi,
>
> On Tue, 24 Jun 2008 18:55:26 +0530, "Arun KS" <getarunks@gmail.com> wrote:
>
>   
>> +static inline void __init omap2evm_init_smc911x(void)
>> +{
>> +       int gpio = OMAP2EVM_ETHR_GPIO_IRQ;
>> +       int ret;
>> +
>> +       ret = gpio_request(gpio, "smc911x IRQ");
>> +       if (ret >= 0)
>> +               gpio_direction_input(gpio);
>> +       else
>> +               printk(KERN_ERR "Failed to request GPIO for smc911x
>>     
>
> this would look better like this:
>
>           if (ret < 0) {
>              printk(KERN_ERR "Failed to request GPIO %d for smc911x IRQ\n",
> gpio);
>              return;
>           }
>
>           gpio_direction_input(gpio);
>
>
> besides this, it looks fine :-)
>
>   


Please do not print this email unless it is absolutely necessary. Spread environmental awareness.

-------------------------------------------------------DISCLAIMER------------------------------------------------------
The information transmitted herewith is confidential and proprietary information intended only for use by the individual or entity to which it is addressed. If the reader of this message is not the intended recipient, you are hereby notified that any review, retransmission, dissemination, distribution, copying or other use of, or taking of any action in reliance upon this information is strictly prohibited. If you have received this communication in error, please contact the sender and delete the material from your computer.
--------------------------------------------------------------------------------------------------------------------------------