From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Netfilter Development Mailinglist <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCHv2] deliver events for conntracks created via ctnetlink
Date: Tue, 24 Jun 2008 19:19:03 +0200 [thread overview]
Message-ID: <48612C87.9050207@netfilter.org> (raw)
In-Reply-To: <48611CA3.1050305@trash.net>
Patrick McHardy wrote:
> Patrick McHardy wrote:
>> A few minor nits:
>>
>>> ...
>
> One more thing: the patch still doesn't follow the correct
> netlink semantic for notifations on changes triggered by
> userspace I described in the review of the first version
> of this patch.
>
> Please always mention which changes requested during a
> review were made and which weren't (any why) when sending
> updated versions.
Sorry, there's no particular reason, I forgot to include this. With
regards to nlmsg_report/nlmsg_notify, I just noticed that the echo
cannot be unset for destroy messages since we call nf_conntrack_event()
inside destroy_conntrack().
--
"Los honestos son inadaptados sociales" -- Les Luthiers
next prev parent reply other threads:[~2008-06-24 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 12:08 [PATCHv2] deliver events for conntracks created via ctnetlink Pablo Neira Ayuso
2008-06-24 15:54 ` Patrick McHardy
2008-06-24 16:11 ` Patrick McHardy
2008-06-24 17:19 ` Pablo Neira Ayuso [this message]
2008-06-24 17:28 ` Patrick McHardy
2008-06-24 16:51 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48612C87.9050207@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.