From: Michael Haggerty <mhagger@alum.mit.edu>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [NON-TOY PATCH] git bisect: introduce 'fixed' and 'unfixed'
Date: Tue, 24 Jun 2008 22:06:51 +0200 [thread overview]
Message-ID: <486153DB.3070502@alum.mit.edu> (raw)
In-Reply-To: <alpine.DEB.1.00.0806241808400.9925@racer>
Johannes Schindelin wrote:
> When you look for a fix instead of a regression, it can be quite hard
> to twist your brain into choosing the correct bisect command between
> 'git bisect bad' and 'git bisect good'.
>
> So introduce the commands 'git bisect fixed' and 'git bisect unfixed'.
It seems to me that your problem is that git-bisect requires the "good"
revision to be older than the "bad" one. If this requirement were
removed, would there still be a need for "fixed" vs. "unfixed"?
A bisection search doesn't care what labels are applied to the two
endpoints, as it only looks for transitions between the labels.
Therefore it should be easy to teach git-bisect to locate either kind of
transition, "bad" -> "good" or "good" -> "bad", depending only on where
the user places the original "good" and "bad" tags.
Michael
next prev parent reply other threads:[~2008-06-24 20:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 14:17 [TOY PATCH] git bisect: introduce 'fixed' and 'unfixed' Johannes Schindelin
2008-06-24 14:42 ` Stephan Beyer
2008-06-24 14:55 ` Johannes Schindelin
2008-06-24 15:16 ` Stephan Beyer
2008-06-24 15:02 ` Nicolas Pitre
2008-06-24 16:38 ` Jeff King
2008-06-24 16:50 ` Johannes Schindelin
2008-06-24 17:09 ` [NON-TOY " Johannes Schindelin
2008-06-24 17:41 ` Jeff King
2008-06-24 19:22 ` Daniel Barkalow
2008-06-24 19:26 ` Johannes Schindelin
2008-06-24 22:30 ` Junio C Hamano
2008-06-27 13:48 ` [PATCH, next version] " Johannes Schindelin
2008-06-27 23:03 ` Junio C Hamano
2008-06-28 13:48 ` Johannes Schindelin
2008-06-28 17:52 ` Junio C Hamano
2008-06-24 19:59 ` [NON-TOY PATCH] " SZEDER Gábor
2008-06-24 20:06 ` Michael Haggerty [this message]
2008-06-24 20:38 ` Johannes Schindelin
2008-06-24 22:31 ` Junio C Hamano
2008-06-24 22:43 ` Nicolas Pitre
2008-06-26 6:03 ` Christian Couder
2008-06-24 22:48 ` Lea Wiemann
2008-06-24 23:53 ` A Large Angry SCM
2008-06-25 7:27 ` Karl Hasselström
2008-06-24 16:54 ` [TOY " Reini Urban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486153DB.3070502@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.