From: Andy Furniss <lists@andyfurniss.entadsl.com>
To: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: netdev@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
Stephen Hemminger <shemminger@osdl.org>
Subject: Re: [PATCH v2 2/2] [iproute2/tc] hfsc: add link layer overhead adaption
Date: Tue, 24 Jun 2008 22:39:24 +0100 [thread overview]
Message-ID: <4861698C.3040007@andyfurniss.entadsl.com> (raw)
In-Reply-To: <20080624225850.nvasycyghwko8k8o@hayate.ip6>
Jussi Kivilinna wrote:
> Quoting Andy Furniss <lists@andyfurniss.entadsl.com>:
>
>> Jussi Kivilinna wrote:
>>> Patch adds 'mpu', 'mtu', 'overhead' and 'linklayer' options to hfsc.
>>> These
>>> options are used to create size table for sch_hfsc. Size table is
>>> only used
>>> and passed to kernel if these options are used.
>>
>>> + unsigned short overhead = 0, mpu = 0;
>>
>> overhead may need to be negative because skb->len on eth is payload + 14
>>
>> Andy.
>
> Ok, I made size tables use signed short for overhead instead. But this
> makes me think should htb/cfq/tfb be changed to support negative
> overhead too? Rate table they use have unsigned overhead.
Yea they should really, somehow - eventually :-) It was discussed here -
http://news.gmane.org/find-root.php?group=gmane.linux.network&article=90386
Andy.
next prev parent reply other threads:[~2008-06-24 21:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 8:55 [PATCH v2 1/2] [iproute2/tc] tc_core: add size table Jussi Kivilinna
2008-06-24 8:55 ` [PATCH v2 2/2] [iproute2/tc] hfsc: add link layer overhead adaption Jussi Kivilinna
2008-06-24 10:14 ` Andy Furniss
2008-06-24 19:58 ` Jussi Kivilinna
2008-06-24 21:39 ` Andy Furniss [this message]
2008-06-25 11:07 ` Patrick McHardy
2008-06-26 23:31 ` Jussi Kivilinna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4861698C.3040007@andyfurniss.entadsl.com \
--to=lists@andyfurniss.entadsl.com \
--cc=jussi.kivilinna@mbnet.fi \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.