From: "H. Peter Anvin" <hpa@zytor.com>
To: Paul Jackson <pj@sgi.com>
Cc: yhlu.kernel@gmail.com, akpm@linux-foundation.org, mingo@elte.hu,
tglx@linutronix.de, steiner@sgi.com, travis@sgi.com,
linux-kernel@vger.kernel.org, ying.huang@intel.com,
andi@firstfloor.org
Subject: Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks
Date: Tue, 24 Jun 2008 19:18:23 -0700 [thread overview]
Message-ID: <4861AAEF.3020103@zytor.com> (raw)
In-Reply-To: <20080624211711.8c6d5105.pj@sgi.com>
Paul Jackson wrote:
> hpa wrote:
>> that would have to be %#10lx.
>
> Hmmm ... the '#' is a good idea, instead of an explicit "0x".
>
> Do we want zero padding as well, with "0#8lx" ?
>
> Zone PFN ranges:
> DMA 0x00000000 -> 0x00001000
> DMA32 0x00001000 -> 0x00100000
> Normal 0x00100000 -> 0x00428000
>
> or right aligned, space padded:
>
> Zone PFN ranges:
> DMA 0x0 -> 0x1000
> DMA32 0x1000 -> 0x100000
> Normal 0x100000 -> 0x428000
>
> I like the zero padding here myself.
>
Yes, zero padding.
What we really should have is %p produce this format. For some odd
reason, right now %p produces numbers without the 0x prefix.
-h
next prev parent reply other threads:[~2008-06-25 2:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 14:21 [PATCH 0/5 v2] x86 boot: various E820 & EFI related fixes - what changed in v2 Paul Jackson
2008-06-22 14:21 ` [PATCH 1/5 v2] x86 boot: e820 code indentation fix Paul Jackson
2008-06-22 14:22 ` [PATCH 2/5 v2] x86 boot: x86_64 efi compiler warning fix Paul Jackson
2008-06-22 14:22 ` [PATCH 3/5 v2] x86 boot: allow overlapping early reserve memory ranges Paul Jackson
2008-06-22 14:22 ` [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks Paul Jackson
2008-06-22 19:38 ` Yinghai Lu
2008-06-23 11:09 ` Paul Jackson
2008-06-24 21:29 ` Yinghai Lu
2008-06-25 1:32 ` Paul Jackson
2008-06-25 1:56 ` H. Peter Anvin
2008-06-25 2:17 ` Paul Jackson
2008-06-25 2:18 ` H. Peter Anvin [this message]
2008-06-25 2:58 ` Linus Torvalds
2008-06-25 3:00 ` Linus Torvalds
2008-06-25 3:08 ` Paul Jackson
2008-06-25 4:04 ` Linus Torvalds
2008-06-25 5:01 ` H. Peter Anvin
2008-06-25 14:42 ` Linus Torvalds
2008-06-25 15:29 ` H. Peter Anvin
2008-06-25 8:04 ` Paul Jackson
2008-06-25 14:53 ` Ingo Molnar
2008-06-26 19:14 ` Sam Ravnborg
2008-06-27 12:00 ` Ingo Molnar
2008-06-27 21:25 ` Sam Ravnborg
2008-06-25 15:00 ` Johannes Berg
2008-06-25 15:19 ` Linus Torvalds
2008-06-25 15:34 ` Johannes Berg
2008-06-27 20:43 ` Denys Vlasenko
2008-06-30 7:58 ` Alexander van Heukelum
2008-06-25 5:05 ` H. Peter Anvin
2008-06-22 14:22 ` [PATCH 5/5 v2] x86 boot: more consistently use type int for node ids Paul Jackson
2008-06-24 11:19 ` [PATCH 0/5 v2] x86 boot: various E820 & EFI related fixes - what changed in v2 Ingo Molnar
2008-06-24 11:30 ` Paul Jackson
2008-06-24 15:45 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2008-06-25 8:56 [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks Marco Cesati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4861AAEF.3020103@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pj@sgi.com \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=yhlu.kernel@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.