All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Toth <stoth@linuxtv.org>
To: stev391@email.com
Cc: linux dvb <linux-dvb@linuxtv.org>
Subject: Re: [linux-dvb] cx23885 driver and DMA timeouts
Date: Wed, 25 Jun 2008 18:53:54 -0400	[thread overview]
Message-ID: <4862CC82.3000205@linuxtv.org> (raw)
In-Reply-To: <20080625223207.289C832675A@ws1-8.us4.outblaze.com>

stev391@email.com wrote:
> Steve,
> 
> I have found the cause of my DMA timeouts, as per your suggestion I 
> checked the sram settings.
> The cause of the issue was in SRAM_CH06 cdt, this was originally set to 
> 0x10480 and is currently set to 0x108d0.  In changeset 7005:a6d2028a4aab 
> you introduced this as an alternative set of values and then in 
> changeset 7464:20a1412b4f1a it was all converted to these values.  I was 
> wondering why this value was required to change?
> 
> I have not yet had the time to analyse these values in detail, but the 
> following are possible options that I/we can persue:
> 
> 1) Set the value back to 0x10480 (diff attached), the following 
> supported cards will use this value (from a quick glance):
>     CX23885_BOARD_HAUPPAUGE_HVR1800lp
>     CX23885_BOARD_HAUPPAUGE_HVR1800
>     CX23885_BOARD_HAUPPAUGE_HVR1250
>     CX23885_BOARD_HAUPPAUGE_HVR1500Q
>     CX23885_BOARD_HAUPPAUGE_HVR1500
>     CX23885_BOARD_HAUPPAUGE_HVR1200
>     CX23885_BOARD_HAUPPAUGE_HVR1700
>     CX23885_BOARD_HAUPPAUGE_HVR1400
>     CX23885_BOARD_DVICO_FUSIONHDTV_7_DUAL_EXP
> 
> 2) Introduce another variable in struct cx23885_board to allow board 
> specific srams.  The sram would not be duplicated in this struct, a 
> second version would be included in cx23885-core.c (similar to the 7005 
> changeset except it is now manual configurable and not switching on PCI 
> id). The down side of this is the cx23885-core.c will be slightly 
> larger, with a larger memory footprint.
> 
> 3) Reallocate entire sram, this would require a detailed look on my 
> behalf to see how much space each variable requires and reallocate it.  
> This will potentially break the cards mentioned in option 1 and will 
> take more time to implement and test. This is highly undesirable my 
> viewpoint.
> 
> 4) Something else? Please suggest a solution...
> 
> Regards,
> 
> Stephen
> 
> diff -Naur v4l-dvb/linux/drivers/media/video/cx23885/cx23885-core.c 
> v4l-dvb1/linux/drivers/media/video/cx23885/cx23885-core.c
> --- v4l-dvb/linux/drivers/media/video/cx23885/cx23885-core.c    
> 2008-06-06 14:57:55.000000000 +1000
> +++ v4l-dvb1/linux/drivers/media/video/cx23885/cx23885-core.c   
> 2008-06-26 08:26:42.000000000 +1000
> @@ -142,7 +142,7 @@
>                 .name           = "TS2 C",
>                 .cmds_start     = 0x10140,
>                 .ctrl_start     = 0x10680,
> -               .cdt            = 0x108d0,
> +               .cdt            = 0x10480,
>                 .fifo_start     = 0x6000,
>                 .fifo_size      = 0x1000,
>                 .ptr1_reg       = DMA5_PTR1,
> 
>     ----- Original Message -----
>     From: "Steven Toth"
>     To: stev391@email.com
>     Subject: Re: [linux-dvb] cx23885 driver and DMA timeouts
>     Date: Mon, 23 Jun 2008 08:51:10 -0400
> 
>     No need to try windows, if you have the driver already running
>     (pascoe's patches) then your chipset and hardware are fine.
> 
>     Sounds like you have a simple merge issue.
> 
>     Try to figure out which parts of the merge actually create the
>     problem then bring that issue back to this list for discussion.
> 
>     Regards,
> 
>     - Steve

Let me go back and look at the existing layout. Something is obviously 
wrong.

We don't want board specific values.

- Steve

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

  reply	other threads:[~2008-06-25 22:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 22:32 [linux-dvb] cx23885 driver and DMA timeouts stev391
2008-06-25 22:53 ` Steven Toth [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-06-22 12:10 stev391
2008-06-23 12:51 ` Steven Toth
2008-06-21  5:22 stev391
2008-06-21 12:54 ` Steven Toth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4862CC82.3000205@linuxtv.org \
    --to=stoth@linuxtv.org \
    --cc=linux-dvb@linuxtv.org \
    --cc=stev391@email.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.