From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rene Herman Subject: Re: [PATCH 2.6.26-rc] ACPI Thermal Zone driver breaks lm-sensors 2 userspace Date: Thu, 26 Jun 2008 01:38:44 +0200 Message-ID: <4862D704.80607@keyaccess.nl> References: <48605935.5070407@shaw.ca> <1214279258.3001.76.camel@rzhang-dt.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtpq1.groni1.gr.home.nl ([213.51.130.200]:57555 "EHLO smtpq1.groni1.gr.home.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753873AbYFYXiA (ORCPT ); Wed, 25 Jun 2008 19:38:00 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Len Brown Cc: Zhang Rui , Linus Torvalds , Robert Hancock , "Mark M. Hoffman" , Hans de Goede , Jean Delvare , linux-acpi@vger.kernel.org, lm-sensors@lm-sensors.org, Linux Kernel On 26-06-08 01:16, Len Brown wrote: > >> +config THERMAL_HWMON >> + bool "Hardware monitoring support" >> + depends on HWMON=y || HWMON=THERMAL > > > for > CONFIG_HWMON=m > CONFIG_THERMAL=y > CONFIG_THERMAL_HWMON=n, always. > > This is not a change to the logic of the existing ifdefs, > but was wondering if this was your intent, Rui. My intentioon in this case. Yes, this should be. THERMAL_HWMON is a bool (as in, not a tristate) that just changes THERMAL. If THERMAL=y, we need HWMON=y or we'd get a link failure. If THERMAL=m, we're okay with either HWMON=y and HWMON=m and if THERMAL=n, we don't care one hoot about THERMAL_HWMON... Rene. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rene Herman Date: Wed, 25 Jun 2008 23:38:44 +0000 Subject: Re: [lm-sensors] [PATCH 2.6.26-rc] ACPI Thermal Zone driver breaks Message-Id: <4862D704.80607@keyaccess.nl> List-Id: References: <48605935.5070407@shaw.ca> <1214279258.3001.76.camel@rzhang-dt.sh.intel.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Len Brown Cc: Zhang Rui , Linus Torvalds , Robert Hancock , "Mark M. Hoffman" , Hans de Goede , Jean Delvare , linux-acpi@vger.kernel.org, lm-sensors@lm-sensors.org, Linux Kernel On 26-06-08 01:16, Len Brown wrote: > >> +config THERMAL_HWMON >> + bool "Hardware monitoring support" >> + depends on HWMON=y || HWMON=THERMAL > > > for > CONFIG_HWMON=m > CONFIG_THERMAL=y > CONFIG_THERMAL_HWMON=n, always. > > This is not a change to the logic of the existing ifdefs, > but was wondering if this was your intent, Rui. My intentioon in this case. Yes, this should be. THERMAL_HWMON is a bool (as in, not a tristate) that just changes THERMAL. If THERMAL=y, we need HWMON=y or we'd get a link failure. If THERMAL=m, we're okay with either HWMON=y and HWMON=m and if THERMAL=n, we don't care one hoot about THERMAL_HWMON... Rene. _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors