From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mtd: CONFIG_NAND_LAZY_SCAN option support
Date: Thu, 26 Jun 2008 11:52:26 -0500 [thread overview]
Message-ID: <4863C94A.2010602@freescale.com> (raw)
In-Reply-To: <4863664A.4020807@emcraft.com>
Ilya Yanok wrote:
> diff --git a/common/cmd_nand.c b/common/cmd_nand.c
> index 37eb41b..6f5d13d 100644
> --- a/common/cmd_nand.c
> +++ b/common/cmd_nand.c
> @@ -236,6 +236,8 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc,
> char *argv[])
> }
> nand = &nand_info[nand_curr_device];
>
> + nand_lazy_scan_finish(nand);
> +
There are other entry points that need to be covered (e.g. do_nandboot,
do_onenand, env_nand, jffs2, etc). Probably better to put the call in
nand_block_isbad().
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 740d3fc..f3ee705 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2652,8 +2652,13 @@ int nand_scan (struct mtd_info *mtd, int maxchips)
> #if 0
> mtd->owner = THIS_MODULE;
> #endif
> +#ifdef CONFIG_NAND_LAZY_SCAN
> + this->options &= ~NAND_BBT_SCANNED;
> + return 0;
> +#else
> /* Build bad block table */
> return this->scan_bbt (mtd);
> +#endif
Is there any reason not to enable this unconditionally?
Also, this patch is whitespace-mangled.
-Scott
next prev parent reply other threads:[~2008-06-26 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 9:50 [U-Boot-Users] [PATCH] mtd: CONFIG_NAND_LAZY_SCAN option support Ilya Yanok
2008-06-26 16:52 ` Scott Wood [this message]
2008-06-30 14:10 ` [U-Boot-Users] [PATCH] mtd: CONFIG_NAND_LAZY_SCAN support (2nd rev) Ilya Yanok
2008-07-06 20:47 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4863C94A.2010602@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.