All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Andi Kleen <andi@firstfloor.org>,
	balbir@linux.vnet.ibm.com,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Suresh B Siddha <suresh.b.siddha@intel.com>,
	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Dipankar Sarma <dipankar@in.ibm.com>,
	Vatsa <vatsa@linux.vnet.ibm.com>,
	Gautham R Shenoy <ego@in.ibm.com>
Subject: Re: [RFC v1] Tunable sched_mc_power_savings=n
Date: Thu, 26 Jun 2008 22:17:00 +0200	[thread overview]
Message-ID: <4863F93C.9040102@firstfloor.org> (raw)
In-Reply-To: <20080626185254.GA12416@dirshya.in.ibm.com>

Vaidyanathan Srinivasan wrote:

Playing devil's advocate here.


> * Andi Kleen <andi@firstfloor.org> [2008-06-26 20:08:41]:
> 
>>> A user could be an application and certain applications can predict their
>>> workload.
>> So you expect the applications to run suid root and change a sysctl?
>> And what happens when two applications run that do that and they have differing
>> requirements? Will they fight over the sysctl?
> 
> System management software and workload monitoring and managing
> software can potentially control the tunable on behalf of the
> applications for best overall power savings and performance.

Does it have the needed information for that? e.g. real time information
on what the system does? I don't think anybody is in a better position
to control that than the kernel.

> Applications with conflicting goals should resolve among themselves.

That sounds wrong to me. Negotiating between conflicting requirements
from different applications is something that kernels are supposed
to do.

> The application with highest performance requirement should win.

That is right, but the kernel can do that based on nice levels
and possibly other information, can't it?


>  The
> power QoS framework set_acceptable_latency() ensures that the lowest
> latency set across the system wins.  

But that only helps kernel drivers, not user space, doesn't it?

> Power management settings affect the entire system.  It may not be
> based on per application priority or nice value.  However if the
> priority of all the applications currently running in the system
> indicate power savings, then the kernel can goto more aggressive power
> saving state.

That's what I meant yes. So if only the file system indexer is running
over night all niced it will run as power efficiently as possible.

> In a small-scale datacenters, peak and off-peak hour settings can be
> potentially done through simple cron jobs.  

Is there any real drawback from only controlling it through nice levels?

Anyways I think the main thing I object to in your proposal is that
your tunable is system global, not per process. I'm also not
sure if a tunable is really a good idea and if the kernel couldn't
do a better job.

-Andi

  parent reply	other threads:[~2008-06-26 20:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 19:11 [RFC v1] Tunable sched_mc_power_savings=n Vaidyanathan Srinivasan
2008-06-26 13:49 ` Andi Kleen
2008-06-26 15:01   ` Dipankar Sarma
2008-06-26 18:31     ` Vaidyanathan Srinivasan
2008-06-26 15:01   ` Balbir Singh
2008-06-26 18:08     ` Andi Kleen
2008-06-26 18:52       ` Vaidyanathan Srinivasan
2008-06-26 19:37         ` David Collier-Brown
2008-06-27  6:50           ` Vaidyanathan Srinivasan
2008-06-26 20:17         ` Andi Kleen [this message]
2008-06-26 21:00           ` Dipankar Sarma
2008-06-26 21:37             ` Andi Kleen
2008-06-26 21:43               ` Peter Zijlstra
2008-06-26 22:38                 ` Andi Kleen
2008-06-27  6:24                   ` Vaidyanathan Srinivasan
2008-06-27  7:51                   ` Peter Zijlstra
2008-06-27  8:06                     ` Andi Kleen
2008-06-28 11:35                       ` Tim Connors
2008-06-28 11:55                         ` Andi Kleen
2008-06-28 12:22                       ` Matthew Garrett
2008-06-28 12:36                         ` Andi Kleen
2008-06-28 12:53                           ` Matthew Garrett
2008-06-28 11:22                   ` Tim Connors
2008-06-29 18:02                     ` David Collier-Brown
2008-06-30  4:57                       ` Vaidyanathan Srinivasan
2008-06-30  5:55                         ` Tim Connors
2008-06-30 14:18                         ` David Collier-Brown
2008-06-30 14:31                           ` Andi Kleen
2008-06-27  4:54               ` Dipankar Sarma
2008-06-27  8:03                 ` Andi Kleen
2008-06-30 16:10                   ` Dipankar Sarma
2008-06-27  7:19           ` Vaidyanathan Srinivasan
2008-06-27  4:15       ` Balbir Singh
2008-06-27  8:08 ` KOSAKI Motohiro
2008-06-27  8:50   ` Vaidyanathan Srinivasan
2008-06-27 12:54   ` David Collier-Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4863F93C.9040102@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=dipankar@in.ibm.com \
    --cc=ego@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=suresh.b.siddha@intel.com \
    --cc=vatsa@linux.vnet.ibm.com \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.