All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pl@us.ibm.com
Subject: Re: [PATCH 1/3] ixgbe: fix EEH recovery during reset on PPC
Date: Fri, 27 Jun 2008 01:33:47 -0400	[thread overview]
Message-ID: <48647BBB.9040805@garzik.org> (raw)
In-Reply-To: <20080625000036.16592.6621.stgit@localhost.localdomain>

Jeff Kirsher wrote:
> From: Paul Larson <pl@us.ibm.com>
> 
> EEh is not recovering in a resonable amount of time on PPC during
> ixgbe_down().
> 
> Signed-off-by: Paul Larson <pl@us.ibm.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> 
>  drivers/net/ixgbe/ixgbe_main.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index 7b39394..5774377 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -1969,7 +1969,8 @@ void ixgbe_down(struct ixgbe_adapter *adapter)
>  	netif_carrier_off(netdev);
>  	netif_stop_queue(netdev);
>  
> -	ixgbe_reset(adapter);
> +	if (!pci_channel_offline(adapter->pdev))
> +		ixgbe_reset(adapter);
>  	ixgbe_clean_all_tx_rings(adapter);

applied 1-3



      parent reply	other threads:[~2008-06-27  5:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25  0:00 [PATCH 1/3] ixgbe: fix EEH recovery during reset on PPC Jeff Kirsher
2008-06-25  0:01 ` [PATCH 2/3] igb: " Jeff Kirsher
2008-06-25  0:01 ` [PATCH 3/3] e1000e: " Jeff Kirsher
2008-06-27  4:56   ` Jeff Garzik
2008-06-27  5:52     ` Jeff Kirsher
2008-06-27  5:33 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48647BBB.9040805@garzik.org \
    --to=jeff@garzik.org \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pl@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.