From: Jeff Garzik <jeff@garzik.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org
Subject: Re: [PATCH] tc35815: Mark carrier-off before starting PHY
Date: Fri, 27 Jun 2008 01:34:03 -0400 [thread overview]
Message-ID: <48647BCB.80700@garzik.org> (raw)
In-Reply-To: <20080625.114101.102912128.nemoto@toshiba-tops.co.jp>
Atsushi Nemoto wrote:
> Call netif_carrier_off() before starting PHY device. This is a
> behavior before converting to generic PHY layer.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index 10e4e85..dccea52 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -1394,6 +1394,7 @@ tc35815_open(struct net_device *dev)
> tc35815_chip_init(dev);
> spin_unlock_irq(&lp->lock);
>
> + netif_carrier_off(dev);
> /* schedule a link state check */
> phy_start(lp->phy_dev);
>
> @@ -2453,6 +2454,7 @@ static int tc35815_resume(struct pci_dev *pdev)
> return 0;
> pci_set_power_state(pdev, PCI_D0);
> tc35815_restart(dev);
> + netif_carrier_off(dev);
> if (lp->phy_dev)
applied
prev parent reply other threads:[~2008-06-27 5:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 2:41 [PATCH] tc35815: Mark carrier-off before starting PHY Atsushi Nemoto
2008-06-27 5:34 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48647BCB.80700@garzik.org \
--to=jeff@garzik.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.