From: Jeff Garzik <jeff@garzik.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCHv2] ata: endianness annotations in pata drivers
Date: Fri, 27 Jun 2008 02:56:29 -0400 [thread overview]
Message-ID: <48648F1D.9040509@garzik.org> (raw)
In-Reply-To: <1213834603.2125.34.camel@brick>
Harvey Harrison wrote:
> drivers/ata/pata_qdi.c:142:9: warning: incorrect type in assignment (different base types)
> drivers/ata/pata_qdi.c:142:9: expected unsigned int [unsigned] [usertype] pad
> drivers/ata/pata_qdi.c:142:9: got restricted __le32 [usertype] <noident>
> drivers/ata/pata_qdi.c:146:15: warning: cast to restricted __le32
>
> drivers/ata/pata_winbond.c:110:9: warning: incorrect type in assignment (different base types)
> drivers/ata/pata_winbond.c:110:9: expected unsigned int [unsigned] [usertype] pad
> drivers/ata/pata_winbond.c:110:9: got restricted __le32 [usertype] <noident>
> drivers/ata/pata_winbond.c:114:15: warning: cast to restricted __le32
>
> drivers/ata/pata_legacy.c:310:9: warning: incorrect type in assignment (different base types)
> drivers/ata/pata_legacy.c:310:9: expected unsigned int [unsigned] [usertype] pad
> drivers/ata/pata_legacy.c:310:9: got restricted __le32 [usertype] <noident>
> drivers/ata/pata_legacy.c:314:15: warning: cast to restricted __le32
> drivers/ata/pata_legacy.c:752:11: warning: cast to restricted __le32
> drivers/ata/pata_legacy.c:756:9: warning: incorrect type in assignment (different base types)
> drivers/ata/pata_legacy.c:756:9: expected unsigned int [unsigned] [addressable] [assigned] [usertype] pad
> drivers/ata/pata_legacy.c:756:9: got restricted __le32 [usertype] <noident>
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> Al, have incorporated your comments.
>
> drivers/ata/pata_legacy.c | 10 ++++------
> drivers/ata/pata_qdi.c | 2 +-
> drivers/ata/pata_winbond.c | 2 +-
> 3 files changed, 6 insertions(+), 8 deletions(-)
applied
prev parent reply other threads:[~2008-06-27 6:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 22:53 [PATCH] ata: endianness annotations in pata drivers Harvey Harrison
2008-06-18 23:33 ` Al Viro
2008-06-19 0:16 ` [PATCHv2] " Harvey Harrison
2008-06-19 14:55 ` Alan Cox
2008-06-27 6:56 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48648F1D.9040509@garzik.org \
--to=jeff@garzik.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.