From: Andi Kleen <andi@firstfloor.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH, RFC] fasync() BKL pushdown (take 2)
Date: Fri, 27 Jun 2008 10:48:32 +0200 [thread overview]
Message-ID: <4864A960.7010807@firstfloor.org> (raw)
In-Reply-To: <20080625163052.344a2957@bike.lwn.net>
Jonathan Corbet wrote:
> On Fri, 20 Jun 2008 21:12:51 +0200
> Andi Kleen <andi@firstfloor.org> wrote:
>
>> Some devices do state change even when the reference count is > 0.
>> Would need to double check it's all ok with the fasync list.
>
> OK, I've gone over all of the fasync() definitions again with an eye
> toward convincing myself that the fasync list would not get cleared,
> freed, or otherwise molested if fasync() runs without BKL protection.
> I focused especially on other code (open(), ioctl()) which might still
> run with the BKL. The result was two more pushdowns in spots where I
> wasn't sure; chance are both are unnecessary.
Ok fine for me then. I haven't read it again in detail, but it sounds
good now.
I still think it would be better to somehow compile break external users,
but that would be only the icing on the cake.
Acked-by: Andi Kleen <ak@linux.intel.com>
-Andi
next prev parent reply other threads:[~2008-06-27 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 17:29 [PATCH, RFC] fasync() BKL pushdown Jonathan Corbet
2008-06-20 17:55 ` Andi Kleen
2008-06-20 19:09 ` Jonathan Corbet
2008-06-20 19:12 ` Andi Kleen
2008-06-25 22:30 ` [PATCH, RFC] fasync() BKL pushdown (take 2) Jonathan Corbet
2008-06-27 8:48 ` Andi Kleen [this message]
2008-06-20 20:58 ` [PATCH, RFC] fasync() BKL pushdown Arjan van de Ven
2008-06-20 21:05 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4864A960.7010807@firstfloor.org \
--to=andi@firstfloor.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.