From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D80DC2D0A3 for ; Fri, 6 Nov 2020 10:54:42 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 7873B2072E for ; Fri, 6 Nov 2020 10:54:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WThvWAsg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7873B2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AEC754B83B; Fri, 6 Nov 2020 05:54:40 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N1hBTbvv99l0; Fri, 6 Nov 2020 05:54:38 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 492E64B83E; Fri, 6 Nov 2020 05:54:38 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4BF1C4B835 for ; Fri, 6 Nov 2020 05:54:36 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w2-6eUkRaRsP for ; Fri, 6 Nov 2020 05:54:35 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 526024B831 for ; Fri, 6 Nov 2020 05:54:35 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF03D20724; Fri, 6 Nov 2020 10:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604660074; bh=OnTmyL0jGfWHius5cIOnjkdLCJl2+U5PH7ORvDNG+NI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WThvWAsgUak++vYWiIrwyBjo77fcNOCS3jrGoXZwUy6qsIWOTyVJJMS276U59Wjs0 VR1pwkfN1pl3eFwHQhg6po8IiZmYDpMMcuBkgTPkI68ZsAJpnmQS64hb8vzaiFB54F kF16b9KRsHShzdtWQ39eVnBwwZtIJSJj65MJneTs= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kazO3-008A1C-D0; Fri, 06 Nov 2020 10:54:31 +0000 MIME-Version: 1.0 Date: Fri, 06 Nov 2020 10:54:31 +0000 From: Marc Zyngier To: Will Deacon Subject: Re: [PATCH 2/3] KVM: arm64: Rename access_amu() to undef_access() In-Reply-To: <20201105225020.GE8842@willie-the-truck> References: <20201103171445.271195-1-maz@kernel.org> <20201103171445.271195-3-maz@kernel.org> <20201105225020.GE8842@willie-the-truck> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <48655b6266c39555edc614274d1d9877@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: will@kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, liangpeng10@huawei.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2020-11-05 22:50, Will Deacon wrote: > On Tue, Nov 03, 2020 at 05:14:44PM +0000, Marc Zyngier wrote: >> The only thing that access_amu() does is to inject an UNDEF exception, >> so let's rename it to the clearer undef_access(). We'll reuse that >> for some other system registers. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/kvm/sys_regs.c | 28 ++++++++++++++-------------- >> 1 file changed, 14 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c >> index 61789027b92b..fafaa81bf1f6 100644 >> --- a/arch/arm64/kvm/sys_regs.c >> +++ b/arch/arm64/kvm/sys_regs.c >> @@ -1038,8 +1038,8 @@ static bool access_pmuserenr(struct kvm_vcpu >> *vcpu, struct sys_reg_params *p, >> { SYS_DESC(SYS_PMEVTYPERn_EL0(n)), \ >> access_pmu_evtyper, reset_unknown, (PMEVTYPER0_EL0 + n), } >> >> -static bool access_amu(struct kvm_vcpu *vcpu, struct sys_reg_params >> *p, >> - const struct sys_reg_desc *r) >> +static bool undef_access(struct kvm_vcpu *vcpu, struct sys_reg_params >> *p, >> + const struct sys_reg_desc *r) >> { >> kvm_inject_undefined(vcpu); > > This seems to be identical to trap_ptrauth(). Shall we give it the same > treatment? Yes. MTE is also doing the same thing, so let's grind them all. M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC92C2D0A3 for ; Fri, 6 Nov 2020 10:55:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F7A920724 for ; Fri, 6 Nov 2020 10:55:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Rw7k7SUt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WThvWAsg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F7A920724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S+s79240ggmeZuRq1xG603BxfaX3Wh0nrWkN4x7NQWM=; b=Rw7k7SUtatcOgn4ofUXfQStEC Hv7Hq+bDkUH4Mhh2g5qaT2t4LoK5Y1Jb5IjbhQPX8dAFdf/zhjE7d/WV6DU4N32xU4Jcdz1PPMjxT VV74wBIko3GWWDrxzeiyyMefUVOROoQv1eG8P3rftx48wSbO/3DOhybPP1s40WOZt0w8zOwc7EN4N R5E5BCi3ooazm2I9C2L+G0DSI0TMSCX/JbY5pQXrFIDk1xd7BhIYDhyG2MfugS0XY9iLxHSmMWBof KBcRQDySefWFe3P6WZUJoEUC4Tofo1y6VM3Czmk6+DYg1M1BMKNHV2GjCQKerxssL5tL/BXpnlVSb dhDrEyzog==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kazOA-0006ok-74; Fri, 06 Nov 2020 10:54:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kazO7-0006oB-A1 for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2020 10:54:36 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF03D20724; Fri, 6 Nov 2020 10:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604660074; bh=OnTmyL0jGfWHius5cIOnjkdLCJl2+U5PH7ORvDNG+NI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WThvWAsgUak++vYWiIrwyBjo77fcNOCS3jrGoXZwUy6qsIWOTyVJJMS276U59Wjs0 VR1pwkfN1pl3eFwHQhg6po8IiZmYDpMMcuBkgTPkI68ZsAJpnmQS64hb8vzaiFB54F kF16b9KRsHShzdtWQ39eVnBwwZtIJSJj65MJneTs= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kazO3-008A1C-D0; Fri, 06 Nov 2020 10:54:31 +0000 MIME-Version: 1.0 Date: Fri, 06 Nov 2020 10:54:31 +0000 From: Marc Zyngier To: Will Deacon Subject: Re: [PATCH 2/3] KVM: arm64: Rename access_amu() to undef_access() In-Reply-To: <20201105225020.GE8842@willie-the-truck> References: <20201103171445.271195-1-maz@kernel.org> <20201103171445.271195-3-maz@kernel.org> <20201105225020.GE8842@willie-the-truck> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <48655b6266c39555edc614274d1d9877@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: will@kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, liangpeng10@huawei.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_055435_430244_ADF61779 X-CRM114-Status: GOOD ( 15.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Suzuki K Poulose , Peng Liang , James Morse , Julien Thierry , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-11-05 22:50, Will Deacon wrote: > On Tue, Nov 03, 2020 at 05:14:44PM +0000, Marc Zyngier wrote: >> The only thing that access_amu() does is to inject an UNDEF exception, >> so let's rename it to the clearer undef_access(). We'll reuse that >> for some other system registers. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/kvm/sys_regs.c | 28 ++++++++++++++-------------- >> 1 file changed, 14 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c >> index 61789027b92b..fafaa81bf1f6 100644 >> --- a/arch/arm64/kvm/sys_regs.c >> +++ b/arch/arm64/kvm/sys_regs.c >> @@ -1038,8 +1038,8 @@ static bool access_pmuserenr(struct kvm_vcpu >> *vcpu, struct sys_reg_params *p, >> { SYS_DESC(SYS_PMEVTYPERn_EL0(n)), \ >> access_pmu_evtyper, reset_unknown, (PMEVTYPER0_EL0 + n), } >> >> -static bool access_amu(struct kvm_vcpu *vcpu, struct sys_reg_params >> *p, >> - const struct sys_reg_desc *r) >> +static bool undef_access(struct kvm_vcpu *vcpu, struct sys_reg_params >> *p, >> + const struct sys_reg_desc *r) >> { >> kvm_inject_undefined(vcpu); > > This seems to be identical to trap_ptrauth(). Shall we give it the same > treatment? Yes. MTE is also doing the same thing, so let's grind them all. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE95C2D0A3 for ; Fri, 6 Nov 2020 10:54:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1965A2072E for ; Fri, 6 Nov 2020 10:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604660076; bh=OnTmyL0jGfWHius5cIOnjkdLCJl2+U5PH7ORvDNG+NI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=m4S7qhlJ/1jEjHBnhr2+3tjPTgp/OrjuiQLPvVY3xqNgo6wwgQVOLmeXmedgIedLl CUEHwYLpqHxBv8KXe9umJ4VF9BEGv7lRHZszJKznewkAsf2CXPTIyQpfB/Jq3D6Ong fBWnwg8yLlFVlXlRyMnRWn1bdTsIjfjux5iN7V+I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbgKFKye (ORCPT ); Fri, 6 Nov 2020 05:54:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:37530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbgKFKye (ORCPT ); Fri, 6 Nov 2020 05:54:34 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF03D20724; Fri, 6 Nov 2020 10:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604660074; bh=OnTmyL0jGfWHius5cIOnjkdLCJl2+U5PH7ORvDNG+NI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WThvWAsgUak++vYWiIrwyBjo77fcNOCS3jrGoXZwUy6qsIWOTyVJJMS276U59Wjs0 VR1pwkfN1pl3eFwHQhg6po8IiZmYDpMMcuBkgTPkI68ZsAJpnmQS64hb8vzaiFB54F kF16b9KRsHShzdtWQ39eVnBwwZtIJSJj65MJneTs= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kazO3-008A1C-D0; Fri, 06 Nov 2020 10:54:31 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 06 Nov 2020 10:54:31 +0000 From: Marc Zyngier To: Will Deacon Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Peng Liang , James Morse , Julien Thierry , Suzuki K Poulose , kernel-team@android.com Subject: Re: [PATCH 2/3] KVM: arm64: Rename access_amu() to undef_access() In-Reply-To: <20201105225020.GE8842@willie-the-truck> References: <20201103171445.271195-1-maz@kernel.org> <20201103171445.271195-3-maz@kernel.org> <20201105225020.GE8842@willie-the-truck> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <48655b6266c39555edc614274d1d9877@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: will@kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, liangpeng10@huawei.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2020-11-05 22:50, Will Deacon wrote: > On Tue, Nov 03, 2020 at 05:14:44PM +0000, Marc Zyngier wrote: >> The only thing that access_amu() does is to inject an UNDEF exception, >> so let's rename it to the clearer undef_access(). We'll reuse that >> for some other system registers. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/kvm/sys_regs.c | 28 ++++++++++++++-------------- >> 1 file changed, 14 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c >> index 61789027b92b..fafaa81bf1f6 100644 >> --- a/arch/arm64/kvm/sys_regs.c >> +++ b/arch/arm64/kvm/sys_regs.c >> @@ -1038,8 +1038,8 @@ static bool access_pmuserenr(struct kvm_vcpu >> *vcpu, struct sys_reg_params *p, >> { SYS_DESC(SYS_PMEVTYPERn_EL0(n)), \ >> access_pmu_evtyper, reset_unknown, (PMEVTYPER0_EL0 + n), } >> >> -static bool access_amu(struct kvm_vcpu *vcpu, struct sys_reg_params >> *p, >> - const struct sys_reg_desc *r) >> +static bool undef_access(struct kvm_vcpu *vcpu, struct sys_reg_params >> *p, >> + const struct sys_reg_desc *r) >> { >> kvm_inject_undefined(vcpu); > > This seems to be identical to trap_ptrauth(). Shall we give it the same > treatment? Yes. MTE is also doing the same thing, so let's grind them all. M. -- Jazz is not dead. It just smells funny...