From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@lst.de>
Cc: markgw@sgi.com, xfs@oss.sgi.com
Subject: Re: rfc: kill ino64 mount option
Date: Sat, 28 Jun 2008 14:52:08 -0500 [thread overview]
Message-ID: <48669668.4060204@sandeen.net> (raw)
In-Reply-To: <20080628152540.GB22484@lst.de>
Christoph Hellwig wrote:
> On Fri, Jun 27, 2008 at 11:31:39PM -0500, Eric Sandeen wrote:
>> I guess I'm ambivalent too, is it really that invasive? Maybe 10, 15
>> lines of code looks like?
>
> Currently it's implemented by adding m_inoadd surrounded by an
> #if XFS_BIG_INUMS. This can be cleaned up by adding a helper ala
>
> xfs_ino_t xfs_user_ino(struct xfs_mount *mp, xfs_ino_t ino);
>
> but I don't really see the point as the option seems quite useless. But
> if others thing the option is worth keeping around I'll do the helper
> instead.
Well, to be honest i've never even enabled it :)
how much does xfsqa use it?
I guess I don't really care if it goes.
-Eric
next prev parent reply other threads:[~2008-06-28 19:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 15:39 rfc: kill ino64 mount option Christoph Hellwig
2008-06-28 0:09 ` Dave Chinner
2008-06-28 0:46 ` Mark Goodwin
2008-06-28 4:31 ` Eric Sandeen
2008-06-28 15:25 ` Christoph Hellwig
2008-06-28 19:52 ` Eric Sandeen [this message]
2008-07-01 8:07 ` Christoph Litauer
2008-07-01 14:12 ` Mark Goodwin
2008-07-01 14:45 ` Christoph Litauer
2008-06-28 15:23 ` Christoph Hellwig
2008-06-29 23:13 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48669668.4060204@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@lst.de \
--cc=markgw@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.