From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 07/11] sysfs: Implement sysfs_delete_link and sysfs_rename_link Date: Sun, 29 Jun 2008 12:35:36 +0900 Message-ID: <48670308.5020301@gmail.com> References: <20080618170729.808539948@theryb.frec.bull.fr> <20080618170731.153832341@theryb.frec.bull.fr> <485F06B8.6090902@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Eric W. Biederman" Cc: Benjamin Thery , Greg Kroah-Hartman , Andrew Morton , Daniel Lezcano , Serge Hallyn , linux-kernel@vger.kernel.org, Al Viro , Linux Containers List-Id: containers.vger.kernel.org Eric W. Biederman wrote: > Tejun Heo writes: > >> Ugly but given the current interface limitations... > > Yep. I have been thinking it might be nice to look at what you did with magic symlink > handling. Otherwise we either need to convert everything from sysfs_remove_link to > sysfs_delete_link if we don't want to play whack a mole. I think the current one should do for now. Changing to managed links requires pervasive changes to locking and stuff. I'll clean them up when I refresh the patches I posted a while back. Thanks. -- tejun