From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KCxfH-0004JC-Ga for qemu-devel@nongnu.org; Sun, 29 Jun 2008 10:14:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KCxfH-0004J0-2u for qemu-devel@nongnu.org; Sun, 29 Jun 2008 10:14:03 -0400 Received: from [199.232.76.173] (port=48639 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KCxfG-0004Iu-T2 for qemu-devel@nongnu.org; Sun, 29 Jun 2008 10:14:02 -0400 Received: from il.qumranet.com ([212.179.150.194]:46155) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KCxfG-000460-H5 for qemu-devel@nongnu.org; Sun, 29 Jun 2008 10:14:02 -0400 Message-ID: <486798A9.7060308@qumranet.com> Date: Sun, 29 Jun 2008 17:14:01 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status information. References: <20080629140120.5626.1590.stgit@gleb-debian.qumranet.com.qumranet.com> <20080629140220.5626.33071.stgit@gleb-debian.qumranet.com.qumranet.com> In-Reply-To: <20080629140220.5626.33071.stgit@gleb-debian.qumranet.com.qumranet.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: gleb@qumranet.com Cc: qemu-devel@nongnu.org Gleb Natapov wrote: > The return value is less then zero if interrupt is masked, zero if it > is known that interrupt is lost (due to coalescing) or greater then zero > if interrupt is delivered or was successfully queued for delivery by > interrupt controller. Device emulation can use this info as it pleases. > Included patch adds detection of interrupt coalescing into PIC and APIC > code for edge triggered interrupts. > Instead of negative/positive/zero, consider returning an enum for readability. -- error compiling committee.c: too many arguments to function