From: Lea Wiemann <lewiemann@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: perl t9700 failures?
Date: Mon, 30 Jun 2008 00:56:15 +0200 [thread overview]
Message-ID: <4868130F.2080600@gmail.com> (raw)
In-Reply-To: <7vzlp47zy8.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> +perl -MTest::More -e 0 2>/dev/null || {
> + say skip "Perl Test::More unavailable, skipping test"
That looks fine -- the git scripts that use Git.pm are still tested
separately, so even if this test is skipped, Git.pm can be assumed to
not be broken.
Jakub Narebski wrote:
> +perl -MTest::More -e '' >/dev/null 2>&1 || {
> [...]
> +perl -e 'use 5.006002;' >/dev/null 2>&1 || {
I don't think checking for 5.6.2 (which is the version in which
Test::More was added) is actually necessary. If someone installs
Test::More on an older Perl version, we might as well run the tests --
apparently Git.pm works even with older versions, since
t3701-add-interactive.sh seems to work fine for Linus.
Johannes Schindelin wrote:
> And given that I _actively_ warned [...] I
> am actually a little pleased
Johannes, I'd actually be a little pleased if you either
- stop "actively warning" and start actively sending patches, or
- spare the list (and in particular, my mailbox) your whining.
TIA.
next prev parent reply other threads:[~2008-06-29 22:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-29 19:52 perl t9700 failures? Linus Torvalds
2008-06-29 20:18 ` Junio C Hamano
2008-06-30 1:17 ` Linus Torvalds
2008-06-29 20:23 ` Junio C Hamano
2008-06-29 22:53 ` Jakub Narebski
2008-06-29 22:56 ` Lea Wiemann [this message]
2008-06-30 6:11 ` Johannes Sixt
2008-06-29 20:32 ` [PATCH] Skip Perl interface (Git.pm) tests if requirements not fullfilled Jakub Narebski
2008-06-29 21:55 ` perl t9700 failures? Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4868130F.2080600@gmail.com \
--to=lewiemann@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.