From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [PATCH] Log qemu-dm's message with date, time and pid Date: Mon, 30 Jun 2008 11:45:45 +0200 Message-ID: <4868AB49.9050109@suse.de> References: <4864AE9F.1070207@suse.de> <18532.60906.557913.16067@mariner.uk.xensource.com> <20080630134036.F31B.SHIMADA-YXB@necst.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080630134036.F31B.SHIMADA-YXB@necst.nec.co.jp> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Yuji Shimada Cc: xen-devel@lists.xensource.com, Ian Jackson , Yosuke Iwamatsu List-Id: xen-devel@lists.xenproject.org Yuji Shimada schrieb: > I agree with developing proper logging functions. But without these > functions, I think ioemu-logger is a good solution. > > We can reboot xend by the following command. > # /etc/init.d/xend restart > Running of guest domains must not be affected by rebooting xend. This seems to be a valid point. > I'm sure that ioemu-logger dying is rare case. But there is no guarantee > that it doesn't die. > If xend starts ioemu-logger, xend loses one end of a pipe by rebooting > xend. After that, xend can't associates stdin for ioemu-logger with the > pipe when xend restarts ioemu-logger after ioemu-logger dies. This > problem happens because the life cycle of xend and qemu-dm is different. > So I think to start ioemu-logger by qemu-dm is more simple. > > Using named pipe (FIFO), it's possible to start ioemu-logger by xend. > But sorry, I don't know about python well. Could anyone develope it? I'm under the impression that you're completely missing my (and Ian's) point. Actually, I'm not talking about having ioemu-logger started by xend. I'm talking about not having ioemu-logger at all (at least not as a new external tool). Xen has already too many of these small tools, IMHO, and we shouldn't add even more to them without need. So, please implement it in qemu-dm instead of an external tool, if xend is not possible. Kevin