From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] net: smc911x: Fix can not compile smc911x
Date: Mon, 30 Jun 2008 10:25:40 -0700 [thread overview]
Message-ID: <48691714.80004@gmail.com> (raw)
In-Reply-To: <29ab51dc0806300145n5d5dbbcdq7a11e3780b71840f@mail.gmail.com>
Nobuhiro,
Nice catch! Thanks.
Wolfgang/Detlev,
Please pull directly.
regards,
Ben
Nobuhiro Iwamatsu wrote:
> When enable CONFIG_DRIVER_SMC911X_16_BIT in smc911x, can not compile it.
> I revised it from "elif" preprocessor to "elif defined".
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>
Acked-by: Ben Warren <biggerbadderben@gmail.com>
> ---
> drivers/net/smc911x.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> index 7555cb9..a2d3cb2 100644
> --- a/drivers/net/smc911x.c
> +++ b/drivers/net/smc911x.c
> @@ -33,7 +33,7 @@
> CONFIG_DRIVER_SMC911X_16_BIT shall be set"
> #endif
>
> -#ifdef CONFIG_DRIVER_SMC911X_32_BIT
> +#if defined (CONFIG_DRIVER_SMC911X_32_BIT)
> static inline u32 reg_read(u32 addr)
> {
> return *(volatile u32*)addr;
> @@ -42,7 +42,7 @@ static inline void reg_write(u32 addr, u32 val)
> {
> *(volatile u32*)addr = val;
> }
> -#elif CONFIG_DRIVER_SMC911X_16_BIT
> +#elif defined (CONFIG_DRIVER_SMC911X_16_BIT)
> static inline u32 reg_read(u32 addr)
> {
> volatile u16 *addr_16 = (u16 *)addr;
>
next prev parent reply other threads:[~2008-06-30 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 8:45 [U-Boot-Users] [PATCH] net: smc911x: Fix can not compile smc911x Nobuhiro Iwamatsu
2008-06-30 10:04 ` Jens Gehrlein
2008-06-30 17:25 ` Ben Warren [this message]
2008-07-06 22:20 ` Wolfgang Denk
2008-07-06 22:20 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48691714.80004@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.