From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yosuke Iwamatsu Subject: Re: [PATCH] xend: open qemu-dm log files in append mode Date: Tue, 01 Jul 2008 13:57:35 +0900 Message-ID: <4869B93F.8010502@ab.jp.nec.com> References: <486323E3.3000407@ab.jp.nec.com> <18531.44047.726185.484243@mariner.uk.xensource.com> <20080626145100.GO20952@redhat.com> <18531.45028.236043.309416@mariner.uk.xensource.com> <4864B35C.6050403@ab.jp.nec.com> <18532.60800.698530.515126@mariner.uk.xensource.com> <4868A541.40800@ab.jp.nec.com> <18536.58536.997240.887299@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <18536.58536.997240.887299@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: Yuji Shimada , xen-devel@lists.xensource.com, berrange@redhat.com List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > Yosuke Iwamatsu writes ("Re: [Xen-devel] [PATCH] xend: open qemu-dm log files in append mode"): >> Done in qemu-log-rotate-config.patch. >> I've set the logrotate count default to 10. It is small enough not to >> annoy users by filling xen log directory with many files, I think. >> >> I also created a patch (qemu-log-append-config.patch) which opens >> qemu-dm logfiles in append mode if the logrotate count is 0. If this >> makes sense, please apply it after qemu-log-rotate-config.patch. > > That's great. And, after a quick review, your patch looks sane to me. > I assume you've tested both cases. Year, tested and it looked working well. > You forgot to add a Signed-Off-By. Signed-off-bys are written inside the attachments themselves, but anyway here is confirmation: Signed-off-by: Yosuke Iwamatsu --Yosuke