From: Li Zefan <lizf@cn.fujitsu.com>
To: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Cc: Paul Menage <menage@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@in.ibm.com>,
Sudhir Kumar <skumar@linux.vnet.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
containers@lists.osdl.org, Paul Jackson <pj@sgi.com>
Subject: Re: Attaching PID 0 to a cgroup
Date: Tue, 01 Jul 2008 18:28:07 +0800 [thread overview]
Message-ID: <486A06B7.7020906@cn.fujitsu.com> (raw)
In-Reply-To: <20080701094734.GE3925@linux.vnet.ibm.com>
CC: Paul Jackson <pj@sgi.com>
Dhaval Giani wrote:
> [put in the wrong alias for containers list correcting it.]
>
> On Tue, Jul 01, 2008 at 03:15:45PM +0530, Dhaval Giani wrote:
>> Hi Paul,
>>
>> Attaching PID 0 to a cgroup caused the current task to be attached to
>> the cgroup. Looking at the code,
>>
[...]
>>
>> I was wondering, why this was done. It seems to be unexpected behavior.
>> Wouldn't something like the following be a better response? (I've used
>> EINVAL, but I can change it to ESRCH if that is better.)
>>
Why is it unexpected? it follows the behavior of cpuset, so this patch will
break backward compatibility of cpuset.
But it's better to document this.
-----------------------------------------
Document the following cgroup usage:
# echo 0 > /dev/cgroup/tasks
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
cgroups.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/cgroups.txt b/Documentation/cgroups.txt
index 824fc02..213f533 100644
--- a/Documentation/cgroups.txt
+++ b/Documentation/cgroups.txt
@@ -390,6 +390,10 @@ If you have several tasks to attach, you have to do it one after another:
...
# /bin/echo PIDn > tasks
+You can attach the current task by echoing 0:
+
+# /bin/echo 0 > tasks
+
3. Kernel API
=============
next prev parent reply other threads:[~2008-07-01 10:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 9:45 Attaching PID 0 to a cgroup Dhaval Giani
2008-07-01 9:47 ` Dhaval Giani
2008-07-01 10:28 ` Li Zefan [this message]
2008-07-01 10:51 ` Dhaval Giani
2008-07-01 18:54 ` Paul Jackson
2008-07-01 19:01 ` Paul Menage
2008-07-01 21:48 ` Andrea Righi
2008-07-01 21:54 ` Dhaval Giani
[not found] ` <20080701215448.GD5893-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-07-03 21:59 ` Matt Helsley
2008-07-03 21:59 ` Matt Helsley
2008-07-03 22:03 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486A06B7.7020906@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=containers@lists.osdl.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=pj@sgi.com \
--cc=skumar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.