All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Burns <lists.xensource.com@adslpipe.co.uk>
To: xen-devel@lists.xensource.com
Subject: Re: MMIO ioremap() error with PCI passthrough
Date: Tue, 01 Jul 2008 16:44:01 +0100	[thread overview]
Message-ID: <486A50C1.7060000@adslpipe.co.uk> (raw)
In-Reply-To: <C48FF03E.235B9%keir.fraser@eu.citrix.com>

On 01/07/2008 14:31, Keir Fraser wrote:

> Well, your analysis is correct, and the size argument to __ioremap() is
> bogus. It shouldn't have been rounded up to 4096 without also rounding down
> the base address. 

Just been having a look and a think, the size isn't being rounded up 
anywhere, the size is actually passed in as 4K from the driver

      dev->lmmio = ioremap(pci_resource_start(pci_dev,0), 0x1000);

Perhaps the rounding up to 8K is happening because the address isn't 
aligned on a page boundary, so is split over two pages?

So I assume it is the driver at fault for mapping a larger resource area 
than the card actually supports?

I'll try changing the size argument to 0x400 and rebuilding the saa7134 
module.

> So, could be a bug specific to the FC8 kernel. 

Actually centos5.2 is the domU, FC8 is the dom0, since it's x86_64, I 
assume it's the Fedora/Redhat forward-port effort, rather than the 
paravirt_ops effort.

  reply	other threads:[~2008-07-01 15:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01  8:17 MMIO ioremap() error with PCI passthrough Andy Burns
2008-07-01  8:30 ` Keir Fraser
2008-07-01  8:58   ` Andy Burns
2008-07-01  9:45     ` Keir Fraser
2008-07-01 13:16       ` Andy Burns
2008-07-01 13:31         ` Keir Fraser
2008-07-01 15:44           ` Andy Burns [this message]
2008-07-01 16:42             ` Andy Burns
2008-07-01 17:15               ` Keir Fraser
2008-07-01 18:50                 ` Andy Burns
2008-07-01 19:24                   ` Andy Burns
2008-07-01 19:57                     ` Keir Fraser
2008-07-01 22:27                       ` Andy Burns
2008-07-02  9:35               ` Andy Burns
2008-07-02 12:54                 ` Andy Burns
2008-07-02 14:09                   ` Andy Burns
2008-07-01 17:10             ` Keir Fraser
2008-07-01 18:52           ` Jeremy Fitzhardinge
2008-07-01  9:09   ` Andy Burns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486A50C1.7060000@adslpipe.co.uk \
    --to=lists.xensource.com@adslpipe.co.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.