From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1 of 2] fbcon: bgcolor fix
Date: Tue, 01 Jul 2008 17:28:10 +0100 [thread overview]
Message-ID: <486A5B1A.6050901@eu.citrix.com> (raw)
In-Reply-To: <alpine.LNX.1.10.0807011750570.20393@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Tuesday 2008-07-01 17:38, Stefano Stabellini wrote:
>
>> The forth bit of the background color is the blink property bit, not the
>> intensity bit, as for the foreground color.
>> Therefore it shouldn't be included in the background color.
>
> I'm a bit skeptical, though I have not tried this.
If you look at the build_attr function in drivers/char/vt.c you can see
that the blink attribute is stored as the forth bit of the background color.
I tried the patches with both an ncurses application and manually using:
echo -en '\E[5m'
and they seems to work fine.
prev parent reply other threads:[~2008-07-01 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 15:38 [PATCH 1 of 2] fbcon: bgcolor fix Stefano Stabellini
2008-07-01 15:51 ` Jan Engelhardt
2008-07-01 16:28 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486A5B1A.6050901@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.