Re: [PATCH] spi: fix the read path in spidev

[Sebastian Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>]

David Brownell wrote:
> On Tuesday 01 July 2008, Sebastian Siewior wrote:
>> This got broken by the recent "fix rmmod $spi_driver while spidev-user is active".
>> I tested the rmmod & write path but didn't check the read path. I am sorry.
>> The read logic changed and spidev_sync_read() + spidev_sync_write() do not return
>> zero on success anymore but the number of bytes that has been transfered over the
>> bus.
>> This patch changes the logic and copy_to_user() gets called again.
> 
> Good catch ... did you observe this failure happening "in the wild"
> or was this a code-inspection kind of thing?
> 
"in the wild". I've been testing HW testing after I rebased to -rc8 and 
somehow I got no error but the receive buffer was empty....

Sebastian

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08