All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naohiro Ooiwa <nooiwa@miraclelinux.com>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [GIT PULL net-next-2.6] IPv6 Updates
Date: Wed, 02 Jul 2008 16:16:09 +0900	[thread overview]
Message-ID: <486B2B39.9090404@miraclelinux.com> (raw)
In-Reply-To: <20080702.123957.75682669.yoshfuji@linux-ipv6.org>

Hi YOSHIFUJI-san

If I'm not missing something, the following code
should be out side of the for-loop.

>
> -		if (local)
> -			return local;
> +			if (local)
> +				return local;
>
> -		if (flags & RT6_LOOKUP_F_IFACE)
> -			return net->ipv6.ip6_null_entry;
> +			if (flags & RT6_LOOKUP_F_IFACE)
> +				return net->ipv6.ip6_null_entry;
> +		}
>  	}

or, it terminates for-loop on the first interface.
Sorry, I should have pointed it out the last time.


Regards,
Naohiro Ooiwa




  parent reply	other threads:[~2008-07-02  7:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-02  3:39 [GIT PULL net-next-2.6] IPv6 Updates YOSHIFUJI Hideaki / 吉藤英明
2008-07-02  6:36 ` Toyo Abe
2008-07-02 10:59   ` Mitsuru Chinen
2008-07-02 16:46     ` Toyo Abe
2008-07-02  7:16 ` Naohiro Ooiwa [this message]
2008-07-02  9:46   ` YOSHIFUJI Hideaki / 吉藤英明

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486B2B39.9090404@miraclelinux.com \
    --to=nooiwa@miraclelinux.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.