From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Wolf <kwolf@suse.de>
Subject: Re: [PATCH] qemu-xen: Fix PV segfault
Date: Wed, 02 Jul 2008 09:54:16 +0200
Message-ID: <486B3428.5000006@suse.de>
References: <4863E1F6.60909@suse.de>
	<18538.27111.959001.890654@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <18538.27111.959001.890654@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Ian Jackson schrieb:
> Kevin Wolf writes ("[PATCH] qemu-xen: Fix PV segfault"):
>> Don't access cur_cpu with CONFIG_DM, for PV machines it is NULL.
> 
> I'm not sure I understand the execution context here properly.  Is
> this for blktap ?  It would be better to make cur_cpu be set to some
> sensible value.

No, this is completely independent of blktap. Currently, PV machines
just don't have a virtual cpu in qemu - in contrary to FV machines which
call a complete pc_machine.init() during their initialization.

Maybe you're right and it would be better to assign even PV machines a
cpu, but I'm not sure what other functionality this implies to
implement. I'll try to look into this.

Kevin