From: Andy Burns <linux-dvb@adslpipe.co.uk>
To: Linux DVB List <linux-dvb@linuxtv.org>
Subject: Re: [linux-dvb] [PATCH] Shrink saa7134 mmio mapped size
Date: Wed, 02 Jul 2008 16:50:06 +0100 [thread overview]
Message-ID: <486BA3AE.1020808@adslpipe.co.uk> (raw)
In-Reply-To: <486BA03D.4040904@adslpipe.co.uk>
The saa7134 driver attempts to map a fixed 4K starting from the base
address of its mmio area, regardless of the actual size of the area.
Any excessive mapping may extend past the end of a page, which goes
un-noticed on bare-metal, but is detected and denied when the card is
used with pci passthrough to a xen domU. If shared IRQ is used the
"pollirq" kernel option may be required in dom0.
Signed-off-by: Andy Burns <andy@burns.net>
---- drivers/media/video/saa7134/saa7134-core.c.orig 2008-07-01
16:46:49.000000000 +0100
+++ drivers/media/video/saa7134/saa7134-core.c 2008-07-02
16:41:37.000000000 +0100
@@ -908,7 +908,8 @@
dev->name,(unsigned long
long)pci_resource_start(pci_dev,0));
goto fail1;
}
- dev->lmmio = ioremap(pci_resource_start(pci_dev,0), 0x1000);
+ dev->lmmio = ioremap(pci_resource_start(pci_dev,0),
+ pci_resource_len(pci_dev,0));
dev->bmmio = (__u8 __iomem *)dev->lmmio;
if (NULL == dev->lmmio) {
err = -EIO;
_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
next prev parent reply other threads:[~2008-07-02 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 17:53 [linux-dvb] saa7134 ioremap() problem Andy Burns
2008-07-02 14:52 ` [linux-dvb] [PATCH] Shrink saa7134 mmio mapped size Andy Burns
2008-07-02 15:12 ` Matthias Schwarzott
2008-07-02 15:35 ` Andy Burns
2008-07-02 15:50 ` Andy Burns [this message]
2008-07-02 20:39 ` hermann pitton
2008-07-02 21:00 ` Andy Burns
2008-07-03 23:09 ` hermann pitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486BA3AE.1020808@adslpipe.co.uk \
--to=linux-dvb@adslpipe.co.uk \
--cc=linux-dvb@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.